Skip to content

Support passive queue declaration in amqp_consumer#5831

Merged
danielnelson merged 4 commits intomasterfrom
amqp-passive-queue
May 20, 2019
Merged

Support passive queue declaration in amqp_consumer#5831
danielnelson merged 4 commits intomasterfrom
amqp-passive-queue

Conversation

@danielnelson
Copy link
Contributor

@danielnelson danielnelson commented May 10, 2019

Required for all PRs:

  • Signed CLA.
  • Associated README.md updated.
  • Has appropriate unit tests.

@danielnelson danielnelson added feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin area/rabbitmq labels May 10, 2019
@danielnelson danielnelson added this to the 1.11.0 milestone May 10, 2019
@danielnelson danielnelson mentioned this pull request May 10, 2019
Closed
3 tasks
@danielnelson
Copy link
Contributor Author

danielnelson commented May 10, 2019

@Esity
Copy link

Esity commented May 16, 2019 •
edited
Loading

So this works for passive queues but it still requires an exchange name to be specified. If I don't and the AMQP creds don't have permission to create an exchange you will get this message

`2019-05-16T17:57:48Z E! [agent] Service for input inputs.amqp_consumer failed to start: error declaring exchange: Exception (403) Reason: "ACCESS_REFUSED - operation not permitted on the default exchange"

2019-05-16T17:57:48Z E! [telegraf] Error running agent: error declaring exchange: Exception (403) Reason: "ACCESS_REFUSED - operation not permitted on the default exchange"`

@danielnelson

@danielnelson
Copy link
Contributor Author

danielnelson commented May 17, 2019

I've updated the plugin to skip exchange declaration when it is set to "", as otherwise it seems to be impossible to use the default exchange and anyway it really should be optional. Similar for bindings, they are now only created when set to a non empty string.

@danielnelson danielnelson merged commit e141518 into master May 20, 2019
@danielnelson danielnelson deleted the amqp-passive-queue branch May 20, 2019 21:38
hwaastad pushed a commit to hwaastad/telegraf that referenced this pull request Jun 13, 2019
@danielnelson
Support passive queue declaration in amqp_consumer (influxdata#5831)
6f49802
bitcharmer pushed a commit to bitcharmer/telegraf that referenced this pull request Oct 18, 2019
@danielnelson @bitcharmer
Support passive queue declaration in amqp_consumer (influxdata#5831)
a2df834
athoune pushed a commit to bearstech/telegraf that referenced this pull request Apr 17, 2020
@danielnelson
Support passive queue declaration in amqp_consumer (influxdata#5831)
9b056c6
idohalevi pushed a commit to idohalevi/telegraf that referenced this pull request Sep 29, 2020
@danielnelson
Support passive queue declaration in amqp_consumer (influxdata#5831)
639db20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@glinton glinton glinton approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area/rabbitmq feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin

Projects

None yet

Milestone

1.11.0

Development

Successfully merging this pull request may close these issues.

3 participants

@danielnelson @Esity @glinton