Merged
Conversation
Contributor
|
+1 |
danielnelson
suggested changes
May 1, 2019
danielnelson
added
area/agent
feat
danielnelson
approved these changes
May 3, 2019
adrianlzt
reviewed
Oct 3, 2019
| // Use year-month-date for readability, unix time to make the file name unique with second precision | ||
| now := time.Now() | ||
| rotatedFilename := fmt.Sprintf(w.filenameRotationTemplate, now.Format(DateFormat), strconv.FormatInt(now.Unix(), 10)) | ||
| if err = os.Rename(w.filename, rotatedFilename); err != nil { |
Contributor
There was a problem hiding this comment.
Maybe compress the rotated file?
https://www.dotnetperls.com/compress-go
Contributor
There was a problem hiding this comment.
Good idea, mind opening a new feature request for compressing the rotated files since this pr has been merged, thanks.
bitcharmer
pushed a commit
to bitcharmer/telegraf
that referenced
this pull request
Oct 18, 2019
athoune
pushed a commit
to bearstech/telegraf
that referenced
this pull request
Apr 17, 2020
idohalevi
pushed a commit
to idohalevi/telegraf
that referenced
this pull request
Sep 29, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Concerns #3393
I took the code from #5547 as a basis and did the following:
This PR uses the new file writer for logging purposes only, but it can be easily plugged in the output file plugin.
Required for all PRs: