Skip to content

Gh webhooks#573

Merged
sparrc merged 11 commits intomasterfrom
ghWebhooks
Jan 26, 2016
Merged

Gh webhooks#573
sparrc merged 11 commits intomasterfrom
ghWebhooks

Conversation

@jackzampolin
Copy link
Contributor

First go at a telegraf plugin. It listens for events pushed out Github and persists relevant data from them to configured outputs.

@sparrc

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these should be 2-space indentation

@sparrc
Copy link
Contributor

sparrc commented Jan 25, 2016

Looks good! Just some comments to address that should get the build working again as well.

Few other things:

  1. Could we rename this plugin to github_webhooks?
  2. Write a README with step-by-step instructions for setting up the webhooks, and what sorts of measurements and fields this will produce (doesn't have to be all of them, just an example would be fine)

@jackzampolin
Copy link
Contributor Author

@sparrc For sure!

@jackzampolin
Copy link
Contributor Author

@sparrc 👀

Godeps Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what happened here, but it shouldn't list itself as a dependency. What does your project source directory look like? is it not $GOPATH/src/github.com/influxdata/telegraf?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its got an internal dependancy. I separated out some stuff into another package. Should I move it all into one package?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what do you mean by internal dependency? I just mean that the telegraf repo shouldn't need to import itself (as an external dependency) in any situation. The Godeps file is for external dependencies only.

@jackzampolin
Copy link
Contributor Author

@sparrc 👀

@sparrc sparrc merged commit 4c74a2d into master Jan 26, 2016
sparrc added a commit that referenced this pull request Jan 26, 2016
@sparrc sparrc deleted the ghWebhooks branch January 28, 2016 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants