Conversation
There was a problem hiding this comment.
these should be 2-space indentation
|
Looks good! Just some comments to address that should get the build working again as well. Few other things:
|
|
@sparrc For sure! |
|
@sparrc 👀 |
Godeps
Outdated
There was a problem hiding this comment.
Not sure what happened here, but it shouldn't list itself as a dependency. What does your project source directory look like? is it not $GOPATH/src/github.com/influxdata/telegraf?
There was a problem hiding this comment.
Its got an internal dependancy. I separated out some stuff into another package. Should I move it all into one package?
There was a problem hiding this comment.
what do you mean by internal dependency? I just mean that the telegraf repo shouldn't need to import itself (as an external dependency) in any situation. The Godeps file is for external dependencies only.
|
@sparrc 👀 |
First go at a telegraf plugin. It listens for events pushed out Github and persists relevant data from them to configured outputs.
@sparrc