Skip to content

adding cmdline procstat#5681

Merged
danielnelson merged 6 commits intoinfluxdata:masterfrom
scottprichard:master
Apr 11, 2019
Merged

adding cmdline procstat#5681
danielnelson merged 6 commits intoinfluxdata:masterfrom
scottprichard:master

Conversation

@scottprichard
Copy link
Contributor

@scottprichard scottprichard commented Apr 4, 2019

closes #1873

Required for all PRs:

  • Signed CLA.
  • Associated README.md updated.
  • Has appropriate unit tests.

@scottprichard
Copy link
Contributor Author

scottprichard commented Apr 4, 2019

pulled master in...same thing as:
Added Cmdline to procstat #3131
@danielnelson / @glinton

@scottprichard
Copy link
Contributor Author

ready to merge, would be nice to get someone with write access to review this and merge it in

@danielnelson danielnelson added area/procstat feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin labels Apr 6, 2019
@scottprichard
Copy link
Contributor Author

@danielnelson 🙏

Copy link
Contributor

@glinton glinton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@glinton glinton mentioned this pull request Apr 8, 2019
3 tasks
@danielnelson
Copy link
Contributor

PR is good but I am a little nervous about this value due to the potential length and contents of this data. Let's do as suggested in #1873 (comment) and add a new option that, when enabled, will add this data as a tag. The option would be disabled by default.

## When true add the full cmdline as a tag.
# cmdline_tag = false

Also make sure to update the README to list the new item.

@scottprichard
Copy link
Contributor Author

@danielnelson can you review ?

@danielnelson danielnelson added this to the 1.11.0 milestone Apr 11, 2019
@danielnelson danielnelson merged commit d2666d0 into influxdata:master Apr 11, 2019
@danielnelson
Copy link
Contributor

Great, thank you!

@scottprichard
Copy link
Contributor Author

@danielnelson not in 1.10.3 ? when can I expect 1.11.0 to be cut ? or can this get put into the next minor ?

@danielnelson
Copy link
Contributor

1.11 should be released near the beginning of June, this isn't something we would put into a patch release but it should be easy to create a custom package with docker or you can use one of the nightly builds

dupondje pushed a commit to dupondje/telegraf that referenced this pull request Apr 22, 2019
hwaastad pushed a commit to hwaastad/telegraf that referenced this pull request Jun 13, 2019
bitcharmer pushed a commit to bitcharmer/telegraf that referenced this pull request Oct 18, 2019
athoune pushed a commit to bearstech/telegraf that referenced this pull request Apr 17, 2020
dloucasfx pushed a commit to signalfx/telegraf that referenced this pull request Nov 30, 2020
dloucasfx added a commit to signalfx/telegraf that referenced this pull request Nov 30, 2020
Add cmdline tag to procstat input (influxdata#5681) (cherry pick)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/procstat feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin

Projects

None yet

Development

Successfully merging this pull request may close these issues.

get full process path via procstat as TAG

3 participants