Skip to content

Fix aggregator window and shutdown of multiple aggregators#5644

Merged
danielnelson merged 2 commits intomasterfrom
fix-aggregator-window
Mar 29, 2019
Merged

Fix aggregator window and shutdown of multiple aggregators#5644
danielnelson merged 2 commits intomasterfrom
fix-aggregator-window

Conversation

@danielnelson
Copy link
Contributor

closes #5637
closes #5595

Required for all PRs:

  • Signed CLA.
  • Associated README.md updated.
  • Has appropriate unit tests.

@danielnelson danielnelson added fix pr to fix corresponding bug area/agent labels Mar 27, 2019
@danielnelson danielnelson added this to the 1.10.2 milestone Mar 27, 2019
@danielnelson
Copy link
Contributor Author

@toni-moreno @sbengo Here are some builds with the aggregator fix, would be very appreciated if you could try them out.

@sbengo
Copy link

sbengo commented Mar 29, 2019

Hi @danielnelson , thanks the PR!

I have been testing on the RH and it seems that it is giving OK results.

I have done 2 test on our RH 7.5 VM:

A - File input

> select sum(resp_time_count) from apachelog2 where time > now() - 4h group by time(1m),request
name: apachelog2
tags: request=/200_1sec.php
time                sum
----                ---
1553845260000000000 60
1553845320000000000 60
1553845380000000000 60
1553845440000000000 60

name: apachelog2
tags: request=/200_2sec.php
time                sum
----                ---
1553845260000000000 30
1553845320000000000 30
1553845380000000000 30
1553845440000000000 30

B - Original tail with tag routing

> select sum(resp_time_count) from apachelog2 where time > now() - 4m group by time(1m),request
name: apachelog2
tags: request=/200_1sec.php
time                sum
----                ---
1553852760000000000
1553852820000000000 60
1553852880000000000 60
1553852940000000000 60
1553853000000000000 60

name: apachelog2
tags: request=/200_2sec.php
time                sum
----                ---
1553852760000000000
1553852820000000000 30
1553852880000000000 30
1553852940000000000 30
1553853000000000000 30

More info:

Dropped metrics are 0 now (expected behaviour):

> select non_negative_derivative(last(metrics_dropped),1m) from "internal_aggregate" where time  > now() - 4m group by time(1m);
name: internal_aggregate
time                non_negative_derivative
----                -----------------------
1553852820000000000 0
1553852880000000000 0
1553852940000000000 0
1553853000000000000 0

@danielnelson danielnelson merged commit 4e3244c into master Mar 29, 2019
@danielnelson danielnelson deleted the fix-aggregator-window branch March 29, 2019 22:40
danielnelson added a commit that referenced this pull request Mar 29, 2019
dupondje pushed a commit to dupondje/telegraf that referenced this pull request Apr 22, 2019
hwaastad pushed a commit to hwaastad/telegraf that referenced this pull request Jun 13, 2019
bitcharmer pushed a commit to bitcharmer/telegraf that referenced this pull request Oct 18, 2019
athoune pushed a commit to bearstech/telegraf that referenced this pull request Apr 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/agent fix pr to fix corresponding bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Panic during shutdown of multiple aggregators Basicstats counter not working as expected

2 participants