Fix dropwizard parsing error for metrics that need escaped#4142
Merged
danielnelson merged 1 commit intomasterfrom May 14, 2018
Merged
Fix dropwizard parsing error for metrics that need escaped#4142danielnelson merged 1 commit intomasterfrom
danielnelson merged 1 commit intomasterfrom
Conversation
If the dropwizard parser cannot convert the metric name into a valid line protocol series then we will accept the name as is.
Contributor
Author
|
@atzoum Can you review/test? |
Contributor
|
LGTM :) |
danielnelson
added a commit
that referenced
this pull request
May 14, 2018
If the dropwizard parser cannot convert the metric name into a valid line protocol series then we will accept the name as is. (cherry picked from commit 0af40a8)
arkady-emelyanov
pushed a commit
to arkady-emelyanov/telegraf
that referenced
this pull request
May 18, 2018
…a#4142) If the dropwizard parser cannot convert the metric name into a valid line protocol series then we will accept the name as is.
leodido
pushed a commit
that referenced
this pull request
May 22, 2018
If the dropwizard parser cannot convert the metric name into a valid line protocol series then we will accept the name as is.
MrMaxBuilds
pushed a commit
that referenced
this pull request
Jun 26, 2018
If the dropwizard parser cannot convert the metric name into a valid line protocol series then we will accept the name as is.
otherpirate
pushed a commit
to otherpirate/telegraf
that referenced
this pull request
Mar 15, 2019
…a#4142) If the dropwizard parser cannot convert the metric name into a valid line protocol series then we will accept the name as is.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the dropwizard parser cannot convert the metric name into a valid line protocol series then we will accept the name as is.
This adds a way to parse only the
<measurement>,<tagset>portion of line protocol and uses it to create new metrics instead of serializing the entire dropwizard metric to line protocol. Anything that would require escaping to be valid cannot be converted, because escaping it fully would prevent tags from being extracted.Required for all PRs: