New parameter to force the interval of gather for sysstat#4068
New parameter to force the interval of gather for sysstat#4068danielnelson merged 1 commit intoinfluxdata:masterfrom
Conversation
Added new config parameter for sysstat plugin, sadc_interval, to force the gather interval of the sadc command. This is useful when we have configured jitter in the agent, because jitter breaks the measurement of the interval used in sadc. Example: - agent with interval=10, jitter=5 - sysstat is started in t=0 and runs sadc with interval=1 - next execution of sysstat is in t=14 (interval + some jitter) - sysstat plugin set the value of "s.interval" to 14s - sadc is run with interval=13 (s.interval - parseInterval) - sysstat plugin is killed because is taking longer that collection interval
|
Thanks @adrianlzt, I've been wondering if we should always require a hard timeout, and completely remove the automatic computation of the interval size. We would of course set a default timeout so it would still remain optional, but the timeout would not be dependent on the first collection. Do you think this is a good idea? |
|
closes #3840 |
|
The computation of the interval size is a little bit hacky and I guess it will cause problems, because of the jitter or because sadc or sadf being slow. I guess a fixed interval could be useful, but you are going to miss some data between runs. Maybe allowing to use this plugin in two different forms could be better. |
|
I confess I'm not up to speed on how sysstat works. This is a step in the right direction but I will probably need more advice at some point in the future. |
Added new config parameter for sysstat plugin, sadc_interval, to force
the gather interval of the sadc command.
This is useful when we have configured jitter in the agent, because
jitter breaks the measurement of the interval used in sadc.
Example:
interval
Required for all PRs: