Skip to content

Add docker input server version#4035

Merged
danielnelson merged 3 commits intomasterfrom
docker-server-version
Apr 23, 2018
Merged

Add docker input server version#4035
danielnelson merged 3 commits intomasterfrom
docker-server-version

Conversation

@danielnelson
Copy link
Contributor

closes #4029

Required for all PRs:

  • Signed CLA.
  • Associated README.md updated.
  • Has appropriate unit tests.

@danielnelson danielnelson added the feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin label Apr 17, 2018
@danielnelson danielnelson added this to the 1.7.0 milestone Apr 17, 2018
@danielnelson
Copy link
Contributor Author

@rdxmb Can you review?

@rdxmb
Copy link
Contributor

rdxmb commented Apr 18, 2018

Oh, I am not a Go-developer, so I cannot make a "real review". But, I can have a look at it, of course.

What I think about is if we need the tag really with all measurements. Having it with docker could be enough, I guess.

@danielnelson
Copy link
Contributor Author

Hmm, maybe it should be a string field then, what sort of queries are you planning to use?

@rdxmb
Copy link
Contributor

rdxmb commented Apr 20, 2018

As mostly the strings I use are stored as tags, I did not have the idea to use a string field for that.

However, for anybody else a use-case could also be to get what engine-version is running under a container. For that, your PR would be the best.

My personal use case is to just check if the docker-engines are up-to-date. So for now I am very flexible about the query.

@danielnelson danielnelson merged commit 9f4752b into master Apr 23, 2018
@danielnelson danielnelson deleted the docker-server-version branch April 23, 2018 22:09
@danielnelson
Copy link
Contributor Author

I think having it as a tag to all of the docker_* measurements will end up be the least confusing.

arkady-emelyanov pushed a commit to arkady-emelyanov/telegraf that referenced this pull request May 18, 2018
MrMaxBuilds pushed a commit that referenced this pull request Jun 26, 2018
otherpirate pushed a commit to otherpirate/telegraf that referenced this pull request Mar 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/docker feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin

Projects

None yet

Development

Successfully merging this pull request may close these issues.

FeatureRequest: add docker engine version to inputs.docker

2 participants