Skip to content

aggregator: move time.now into the aggregator#3693

Merged
danielnelson merged 1 commit intoinfluxdata:masterfrom
piotr1212:agg_timing
Jan 19, 2018
Merged

aggregator: move time.now into the aggregator#3693
danielnelson merged 1 commit intoinfluxdata:masterfrom
piotr1212:agg_timing

Conversation

@piotr1212
Copy link
Contributor

By the time the aggregator.run() was called about 600ms already passed since setting now which was skewing up the aggregation intervals and skipping metrics.

Required for all PRs:

  • Signed CLA.
  • Associated README.md updated.
  • Has appropriate unit tests.

By the time the aggregator.run() was called about 600ms already passed since setting now which was skewing up the aggregation intervals and skipping metrics.
@piotr1212
Copy link
Contributor Author

obsoletes #3688

@danielnelson danielnelson added this to the 1.5.2 milestone Jan 19, 2018
@danielnelson danielnelson added the fix pr to fix corresponding bug label Jan 19, 2018
@danielnelson danielnelson merged commit 601dc99 into influxdata:master Jan 19, 2018
danielnelson pushed a commit that referenced this pull request Jan 19, 2018
#3693)

By the time the aggregator.run() was called about 600ms already passed since setting now which was skewing up the aggregation intervals and skipping metrics.

(cherry picked from commit 601dc99)
MrMaxBuilds pushed a commit that referenced this pull request Jun 26, 2018
#3693)

By the time the aggregator.run() was called about 600ms already passed since setting now which was skewing up the aggregation intervals and skipping metrics.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fix pr to fix corresponding bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants