add salesforce input plugin#3075
Merged
danielnelson merged 2 commits intoinfluxdata:masterfrom Aug 8, 2017
rody:salesforce_input
Merged
add salesforce input plugin#3075danielnelson merged 2 commits intoinfluxdata:masterfrom rody:salesforce_input
danielnelson merged 2 commits intoinfluxdata:masterfrom
rody:salesforce_input
Conversation
danielnelson
suggested changes
Aug 7, 2017
| snake := matchFirstCap.ReplaceAllString(str, "${1}_${2}") | ||
| snake = matchAllCap.ReplaceAllString(snake, "${1}_${2}") | ||
| return strings.ToLower(snake) | ||
| } |
Contributor
There was a problem hiding this comment.
You can use this function https://github.com/influxdata/telegraf/blob/master/internal/internal.go#L160 for converting to snake case.
| } | ||
|
|
||
| if resp.StatusCode != http.StatusOK { | ||
| return l, fmt.Errorf("Salesforce responded with unexpected status code %d", resp.StatusCode) |
Contributor
There was a problem hiding this comment.
Extra space char in the message
Gather metrics about limits and usage for a Salesforce organization.
- remove salesforce.toSnakeCase() and use internal.SnakeCase() instead - remove extra space character in message
Contributor
Author
|
@danielnelson Thanks for the review! |
Contributor
|
Either way is fine, I always merge pull requests with "squash and merge". |
danielnelson
approved these changes
Aug 8, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gather metrics about limits and usage for a Salesforce organisation.
Required for all PRs: