Fixing win_perf_counters tests#3068
Merged
danielnelson merged 1 commit intoinfluxdata:masterfrom Jul 31, 2017
Merged
Conversation
JeffAshton
force-pushed
the
fixing-win-perf-counter-tests
branch
from
ca56cd5 to
f161e3a
Compare
Contributor
Author
JeffAshton
commented
Jul 28, 2017
| instances[0] = "_Total" | ||
| counters[0] = "Parking Status" | ||
|
|
||
| var expectedCounter string = "Parking_Status" |
Contributor
Author
There was a problem hiding this comment.
These tests were broken as a part of this change set for Sanitize Field name: 015261a
JeffAshton
commented
Jul 28, 2017
| objectname := "Processor Information" | ||
| instances[0] = "_Total" | ||
| instances[1] = "0" | ||
| instances[1] = "0,1" |
Contributor
Author
There was a problem hiding this comment.
Later versions of windows have multi-core support, so these tests didn't pass anymore.
JeffAshton
commented
Jul 28, 2017
| ) | ||
|
|
||
| func TestWinPerfcountersConfigGet1(t *testing.T) { | ||
| validmetrics := itemList{} |
Contributor
Author
There was a problem hiding this comment.
itemList was removed in this pull request #2800
JeffAshton
commented
Jul 28, 2017
|
|
||
| perfobjects[0] = PerfObject | ||
|
|
||
| m := Win_PerfCounters{PrintValid: false, TestName: "ConfigGet1", Object: perfobjects} |
Contributor
Author
There was a problem hiding this comment.
TestName was also removed in this pull request #2800
JeffAshton
commented
Jul 28, 2017
| require.NoError(t, err) | ||
|
|
||
| if len(metrics.items) == 1 { | ||
| var parsedItems = m.GetParsedItemsForTesting() |
Contributor
Author
There was a problem hiding this comment.
Added GetParsedItemsForTesting to satisfy existing tests without too drastic a rewrite
Contributor
|
Thank you |
MrMaxBuilds
pushed a commit
that referenced
this pull request
Jun 26, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses issue #3062
Minimal changes to get the existing unit tests compiling and passing again.
Required for all PRs: