Update default value for Cloudwatch rate limit#2520
Update default value for Cloudwatch rate limit#2520danielnelson merged 4 commits intoinfluxdata:masterfrom
Conversation
sparrc
left a comment
There was a problem hiding this comment.
LGTM, thanks!
please update the changelog
|
PS: also please put that documentation link in the SampleConfig |
fc02b38 to
3fbf706
Compare
3fbf706 to
167aea5
Compare
|
@sparrc Done that and squashed. thanks! |
|
If we're saying cloudwatch has a limit of 400 requests per second, do we really want to default to telegraf using all of it? This means that if telegraf has it maxed out, and someone simply goes to the AWS dashboard and tries to pull up cloudwatch metrics, their browser is going to push it over the limit. Ditto if they have any other system which also uses cloudwatch metrics. Should we not choose a safer default, and let people increase it to the max if the default isn't enough? |
|
it's probably time revive this PR #1795 so that telegraf can pull multiple periods of data in 1 request thus saving the API limit. |
|
@phemmer makes a good point....@AntoineAugusti can you lower the default to ~200? |
|
@sparrc Sure, done |
Follow up of: #2298
New documentation: http://docs.aws.amazon.com/AmazonCloudWatch/latest/monitoring/cloudwatch_limits.html
Rate limit is used for the
GetMetricStatisticsendpoint.Required for all PRs: