Add lock option to the IPtables input plugin#2201
Merged
sparrc merged 3 commits intoinfluxdata:masterfrom Feb 1, 2017
Merged
Conversation
Contributor
|
is there a reason we wouldn't want to always use the lock feature? |
Contributor
Author
|
The "-w" option was added to the 1.4.20 version of IPtables in august 2013 (https://www.netfilter.org/projects/iptables/files/changes-iptables-1.4.20.txt). Maybe this feature should be kept optional for compatibility reasons, in the case where someone would be using Telegraf on a system shipped with an IPtables version older than 1.4.20 ? |
Contributor
|
ok, fair enough 👍 |
sparrc
suggested changes
Jan 24, 2017
Contributor
sparrc
left a comment
sparrc
left a comment
There was a problem hiding this comment.
documentation needs cleaning up and tweaking
plugins/inputs/iptables/iptables.go
Outdated
| ## iptables can be restricted to only list command "iptables -nvL" or "iptables -wnvl" if using 'use_lock = true' | ||
| use_sudo = false | ||
| ## Setting 'use_lock' to true will run iptables with xtables lock support. | ||
| ## This option is useful to avoid iptables concurrency errors when running multiple instances of this plugin. |
Contributor
There was a problem hiding this comment.
limit line length to 80 chars and mention that use_lock simply adds the -w option to the iptables
Doc cleaning
Contributor
Author
|
Doc has been cleaned up |
sparrc
approved these changes
Jan 27, 2017
mlindes
pushed a commit
to Comcast/telegraf
that referenced
this pull request
Feb 6, 2017
* Update README.md * Add lock support to the IPtables input plugin * Update iptables.go Doc cleaning
MrMaxBuilds
pushed a commit
that referenced
this pull request
Jun 26, 2018
* Update README.md * Add lock support to the IPtables input plugin * Update iptables.go Doc cleaning
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds IPtables lock support to the input plugin, related to #2144
Required for all PRs: