fix tail input seeking when used with pipe#2090
Merged
sparrc merged 2 commits intoinfluxdata:masterfrom Dec 16, 2016
phemmer:fix-tail-pipe
Merged
fix tail input seeking when used with pipe#2090sparrc merged 2 commits intoinfluxdata:masterfrom phemmer:fix-tail-pipe
sparrc merged 2 commits intoinfluxdata:masterfrom
phemmer:fix-tail-pipe
Conversation
njwhite
pushed a commit
to njwhite/telegraf
that referenced
this pull request
Jan 31, 2017
MrMaxBuilds
pushed a commit
that referenced
this pull request
Jun 26, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Required for all PRs:
Fixes the
tailinput plugin so that it works with named pipes.Also fixes errors being discarded when tailer dies.
There is however still one problem with reading from a pipe. If there is nobody has the pipe open for writing, when telegraf opens it for read, it'll block.
The simple solution to this is to create the goroutine before opening the file. However this means that the
Start()func will return, and then the goroutine potentially error and die immediately due to some other reason (e.g. permission errors). However we can use theAccumulator.AddError()method to report the error. Not sure if there would be any end-user noticeable effect from such a change.Note that there appears to be a different error in that if the tailer dies, it doesn't start back up, thus requiring a restart of telegraf. But that's out of scope of this issue.
Fixes #2089