fix(inputs.ping): Use deterministic packet IDs to prevent collisions#18870
Merged
Conversation
telegraf-tiger
Bot
added
area/ping
fix
This was referenced May 8, 2026
Hipska
approved these changes
May 8, 2026
Hipska
reviewed
May 8, 2026
Member
Author
|
Thanks for making me think @Hipska! IMO the current implementation is much better as it
Please take a look! |
Hipska
reviewed
May 9, 2026
Hipska
left a comment
Hipska
left a comment
Contributor
There was a problem hiding this comment.
Great new approach! I do have some questions.
Member
Author
|
Addressed your comments @Hipska, please take another look! |
Hipska
approved these changes
May 11, 2026
Hipska
left a comment
Hipska
left a comment
Contributor
There was a problem hiding this comment.
Great implementation! Just a minor comment remark.
Hipska
approved these changes
May 11, 2026
srebhan
added
the
ready for final review
skartikey
reviewed
May 21, 2026
skartikey
approved these changes
May 22, 2026
Contributor
|
Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip. 📦 Click here to get additional PR build artifactsArtifact URLs |
Hipska
reviewed
May 26, 2026
Hipska
left a comment
Hipska
left a comment
Contributor
There was a problem hiding this comment.
Only a few comment typo's
| usedIDsCond.L.Lock() | ||
| defer usedIDsCond.L.Unlock() | ||
|
|
||
| // Wait for an ID to become avaulable |
Contributor
There was a problem hiding this comment.
Suggested change
| // Wait for an ID to become avaulable | |
| // Wait for an ID to become available |
| } | ||
| usedIDsCond.L.Unlock() | ||
|
|
||
| // Signal all waiting pingers to check for the free ID |
Contributor
There was a problem hiding this comment.
Suggested change
| // Signal all waiting pingers to check for the free ID | |
| // Signal one waiting pinger to check for the free ID |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR prevents collisions for native pining when interpreting received packet and doing false assignments to the corresponding sent packet. This false assignment produces wrong timings, mangles statistics and produces wrong results (see #8980 for details).
This PR introduces a deterministic packet-ID assignment to
Pingers accross all plugin instances to allow the underlying library to correctly assign a received packet to its correct sent-packet origin.Checklist
Related issues
resolves #8980