Skip to content

chore(inputs.docker): Convert tests to use mock server#18869

Merged
skartikey merged 2 commits into
influxdata:masterfrom
srebhan:docker_migrate_moby
May 8, 2026
Merged

chore(inputs.docker): Convert tests to use mock server#18869
skartikey merged 2 commits into
influxdata:masterfrom
srebhan:docker_migrate_moby

Conversation

@srebhan

@srebhan srebhan commented May 8, 2026

Copy link
Copy Markdown
Member

Summary

This PR converts the docker unit-tests to use the docker mock server. To do so the PR extends the server to also provide endpoints for the required data. Furthermore, the PR removes some internal tests as they are covered by other tests that go the full gather cycle.

This is preparation work in order to get rid of the deprecated docker client library and switch to the moby library.

Checklist

Related issues

@telegraf-tiger telegraf-tiger Bot added area/docker chore plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins labels May 8, 2026
@telegraf-tiger

telegraf-tiger Bot commented May 8, 2026

Copy link
Copy Markdown
Contributor

@srebhan srebhan added ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. labels May 8, 2026
@srebhan srebhan assigned skartikey and unassigned skartikey May 8, 2026

@skartikey skartikey left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@srebhan Nicely done!

@skartikey skartikey merged commit e47597f into influxdata:master May 8, 2026
27 checks passed
@github-actions github-actions Bot added this to the v1.38.4 milestone May 8, 2026
srebhan added a commit that referenced this pull request May 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/docker chore plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants