Skip to content

fix(outputs.influxdb_v3): Remove duplicate timeout setting#18509

Merged
skartikey merged 1 commit intoinfluxdata:masterfrom
WZH8898:fix-influxdb-v3-timeout-collision
Mar 11, 2026
Merged

fix(outputs.influxdb_v3): Remove duplicate timeout setting#18509
skartikey merged 1 commit intoinfluxdata:masterfrom
WZH8898:fix-influxdb-v3-timeout-collision

Conversation

@WZH8898
Copy link
Copy Markdown
Contributor

@WZH8898 WZH8898 commented Mar 11, 2026

Summary

Fix TOML tag collision in outputs.influxdb_v3 configuration.

The clientConfig struct defines a Timeout field with toml:"timeout", while the embedded HTTPClientConfig also defines the same TOML tag. This causes the TOML parser to detect multiple fields matching timeout and refuse to set the value.

This change removes the duplicated Timeout field and relies on the embedded HTTPClientConfig.Timeout, which already provides the same functionality.

Checklist

  • No AI generated code was used in this PR

Related Issues

resolves #18502

@telegraf-tiger telegraf-tiger bot added fix pr to fix corresponding bug plugin/output 1. Request for new output plugins 2. Issues/PRs that are related to out plugins labels Mar 11, 2026
@telegraf-tiger
Copy link
Copy Markdown
Contributor

@srebhan srebhan changed the title fix(outputs.influxdb_v3): resolve TOML timeout tag collision fix(outputs.influxdb_v3): Remove duplicate timeout setting Mar 11, 2026
Copy link
Copy Markdown
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @WZH8898!

Please keep the PR template next time as a fixed pattern allows us to get an overview easier (e.g. keep resolves instead of changing it to Fixes or removing the second AI choice).

@srebhan srebhan added area/influxdb ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. labels Mar 11, 2026
Copy link
Copy Markdown
Contributor

@skartikey skartikey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@WZH8898 Thanks for the contribution!

@skartikey skartikey merged commit 95e294e into influxdata:master Mar 11, 2026
31 checks passed
@github-actions github-actions bot added this to the v1.38.1 milestone Mar 11, 2026
srebhan pushed a commit that referenced this pull request Mar 16, 2026
Co-authored-by: wanzh <wanzh@nscc-tj.cn>
(cherry picked from commit 95e294e)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/influxdb fix pr to fix corresponding bug plugin/output 1. Request for new output plugins 2. Issues/PRs that are related to out plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

outputs.influxdb_v3: timeout config option broken due to TOML tag collision with embedded HTTPClientConfig

4 participants