Additional output plugin for writing to OpenTSDB using telnet mode#182
Additional output plugin for writing to OpenTSDB using telnet mode#182rplessl wants to merge 14 commits intoinfluxdata:masterfrom
Conversation
…t work in future releases; use -X main.Version=v0.1.8-2-g8c5e1ff
outputs/opentsdb/opentsdb.go
Outdated
There was a problem hiding this comment.
please run go fmt on your code, it looks like you have some space-indented lines here
There was a problem hiding this comment.
fixed thanks for the hint
|
This is great, thanks much @rplessl! I can tell that you read the contributing guidelines :-) 👍 👍 re: unit tests, I'm not sure how much work it's going to be to mock openTSDB, but have you considered trying out a docker image of openTSDB rather than mocking it? The kafka output sink utilizes that for unit testing and it simplified things enormously. |
|
thanks for the hint for unit tests- I will also take a docker image |
|
You can do one or the other....basically would require adding the docker image to the scipts/docker-compose.yml file, then using testutil to get the host that the docker openTSDB is at. That would also make it part of a "long" unit test suite |
…test added docker image unit test with OpenTSDB
added debug statement for debugging OpenTSDB communication
…test Opentsdb output plugin telnet unittest
|
Hi @sparrc: |
|
thanks @rplessl, I'm going to try to merge this today 👍 |
Hi,
This additonal output plugin enables to write from telegraf to OpenTSDB using the telnet mode.
My Unit Tests are not 100% code coverage, at the moment I will write a MOC for OpenTSDB emulation which will follows in a second pull request.
I have signed already the CLA
Thanks for pulling in advance!