Added a new input plugin to check SSL certs by egarbi · Pull Request #1762 · influxdata/telegraf

egarbi · 2016-09-13T18:45:14Z

Required for all PRs:

CHANGELOG.md updated (we recommend not updating this until the PR has been approved by a maintainer)
Sign CLA (if not already signed)
README.md updated (if adding a new plugin)

wcgcoder · 2017-01-11T21:02:50Z

The README.md in this pull request for the plugin is incorrect. The example text for telegraf.conf should read:

# SSL request given a list of servers (server:port) and a timeout
[[inputs.check_ssl]]
  ## Servers ( Default [] )
  servers = ["github.com:443"]
  timeout = "5s"

... in order to fix the lack of quotes and the incorrect variable response_timeout.

I'd love to see this plugin in the main product! Please expedite! 👍

egarbi · 2017-01-13T18:23:32Z

@wcgcoder Thanks for your input, Readme has been fixed however checks are failing for an unrelated issue.

wcgcoder · 2017-01-13T18:35:56Z

Thanks so much. Looks like a problem from outside your plugin. Not sure why as I'm rather new to this, but I was able to manually add your plugin to commit 31a4f03 and build it successfully.

okv · 2017-03-14T23:39:23Z

Hi there.
Any news about this? I also need this functionality.

danielnelson · 2017-03-15T00:02:13Z

@okv We are using the github milestones to prioritize pull requests. When there is new information it will be reflected here.

okv · 2017-03-15T01:11:47Z

will be waiting for it, thanks for your information

mcfedr · 2017-04-11T12:29:03Z

Maybe a separate tool, but how nice would it be to integrate your SSL Labs score into this check? https://github.com/ssllabs/ssllabs-scan

hardinw · 2017-05-16T14:31:44Z

@danielnelson I know you said updates will be posted here, but i'm getting itchy to have this functionality in the official release. Any update on a potential release date?

swestcott · 2017-06-26T22:48:29Z

I've patched the error handling issue on a new branch (fe7235c) and signed the CLA. Does someone want to cherry-pick this or should I raise a new PR? It could be great to get this released with v1.4.

danielnelson · 2017-06-26T23:19:17Z

@egarbi Can you integrate the fix by @swestcott into your branch?

danielnelson · 2017-06-26T23:22:57Z

plugins/inputs/ssl/README.md

+# SSL request given a list of servers (server:port) and a timeout
+[[inputs.check_ssl]]
+  ## Servers ( Default [] )
+  servers = ["github.com:443"]


We shouldn't use a real site as an example, since I'm sure they wouldn't appreciate being polled by Telegraf, you can use example.org instead. Please do this throughout the pull request.

What about other protocols, should this start with tcp://? Then we could support udp and tcp6

danielnelson · 2017-06-26T23:23:45Z

plugins/inputs/ssl/README.md

+### Measurements & Fields:
+
+- ssl_cert
+    - time_to_expire (int) # seconds left for the SSL cert to expire


Appears to be a float, you can format this like - time_to_expire (int, seconds).

What do you think about naming this expire_seconds or similar to indicate units?

danielnelson · 2017-06-26T23:26:09Z

plugins/inputs/ssl/check_ssl.go

+// Gather gets all metric fields and tags and returns any errors it encounters
+func (c *CheckExpire) Gather(acc telegraf.Accumulator) error {
+	errChan := errchan.New(len(c.Servers))
+	for _, server := range c.Servers {


I think we should run these concurrently.

danielnelson · 2017-06-26T23:26:38Z

plugins/inputs/ssl/check_ssl.go

+		certs, err := c.checkHost(server)
+		errChan.C <- err
+		if err != nil {
+			timeToExpire = 0


I'm not sure about this, if there is an error it does not necessarily mean the cert is expired.

danielnelson · 2017-06-26T23:40:25Z

plugins/inputs/ssl/README.md

+# Check SSL Input Plugin
+
+This input plugin will return how much time (in seconds) left for a SSL cert to expire.
+Warning, this check doesnt verify if SSL is valid/secure or not.


We should recommend that the user use a increased interval, since 10s default would be too small.

danielnelson · 2017-06-26T23:41:29Z

plugins/inputs/ssl/README.md

@@ -0,0 +1,32 @@
+# Check SSL Input Plugin


I'm not sure that ssl is the right name for this, maybe it should be x509 or cert?

@danielnelson So, what exactly should I change? Everything? the directory, file names and the references to them?

Yeah, I think we need to change all of this.

danielnelson · 2017-06-26T23:43:11Z

plugins/inputs/ssl/check_ssl.go

+	certs := conn.ConnectionState().PeerCertificates
+
+	if certs == nil || len(certs) < 1 {
+		return nil, errors.New("Could not get server's certificate from the TLS connection.")


Include the name of the server that caused this.

…c4d100f369d60c44d71bc602d702180c42

antoinealb · 2017-11-21T14:03:31Z

Since this PR is pretty stalled, what would be the best way to try to get it merged again ? Pick the patches, apply requested changes and open a new PR ?

egarbi · 2017-11-21T14:46:41Z

@antoinealb if you want to start from where I left, be my guest. This was my first go project ever and I don't really now have much time to spend on this.
Thanks

russorat · 2018-06-22T19:31:41Z

sounds like we should close this in favor of #3768 . Thoughts?

Added a new input plugin to check SSL certs

3162925

nhaugo added this to the 1.2.0 milestone Sep 21, 2016

phemmer mentioned this pull request Oct 30, 2016

[feature request] SSL Certificate Input #1971

Closed

sparrc mentioned this pull request Nov 2, 2016

[wip] SSL Certificate input #1972

Closed

3 tasks

sparrc assigned dgnorton Nov 15, 2016

sparrc added plugin request and removed plugin request labels Nov 26, 2016

sparrc modified the milestones: Future Milestone, 1.2.0 Dec 16, 2016

Fixes default timeout in readme

0b588b5

Merge branch 'master' into master

2e74ebc

danielnelson removed this from the Future Milestone milestone Jun 14, 2017

danielnelson suggested changes Jun 27, 2017

View reviewed changes

by @swestcott taken from github.com/influxdata/telegraf/commit/fe7235…

d72d81f

…c4d100f369d60c44d71bc602d702180c42

danielnelson added feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin and removed feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin request labels Aug 12, 2017

russorat added the new plugin label Jan 20, 2018

danielnelson mentioned this pull request Feb 9, 2018

Adding x509_cert input plugin #3768

Merged

3 tasks

danielnelson closed this Jul 2, 2018

Conversation

egarbi commented Sep 13, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Required for all PRs:

Uh oh!

wcgcoder commented Jan 11, 2017

Uh oh!

egarbi commented Jan 13, 2017

Uh oh!

wcgcoder commented Jan 13, 2017

Uh oh!

okv commented Mar 14, 2017

Uh oh!

danielnelson commented Mar 15, 2017

Uh oh!

okv commented Mar 15, 2017

Uh oh!

mcfedr commented Apr 11, 2017

Uh oh!

hardinw commented May 16, 2017

Uh oh!

swestcott commented Jun 26, 2017

Uh oh!

danielnelson commented Jun 26, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

egarbi Jun 29, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

antoinealb commented Nov 21, 2017

Uh oh!

egarbi commented Nov 21, 2017

Uh oh!

russorat commented Jun 22, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

12 participants

egarbi commented Sep 13, 2016 •

edited

Loading

egarbi Jun 29, 2017 •

edited

Loading