Added sanization of fieldName#1118
Closed
G-regL wants to merge 4 commits intoinfluxdata:masterfrom
G-regL:master
Closed
Added sanization of fieldName#1118G-regL wants to merge 4 commits intoinfluxdata:masterfrom G-regL:master
G-regL wants to merge 4 commits intoinfluxdata:masterfrom
G-regL:master
Conversation
Contributor
|
we might want to start sanitizing win perf counters on collection. Especially so we can replace |
Replace '/[sS]ec' for '_persec' and spaces with underscores.
Contributor
Author
|
That makes sense. Updated the PR to reflect that. |
Contributor
|
thanks @G-regL, could you update the CHANGELOG with a release not about this? This is a breaking change. And on a related note-- do we need to sanitize |
Contributor
Author
|
Sure, I'll update the CHANGELOG. Graphite supports |
Contributor
|
This is good the way it is, I'll merge when the tests pass, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When sending Telegraf data to Graphite, many of the metrics generated by the
win_perf_countersinput plugin aren't properly sanitized, and get ignored by Carbon.For example, for the following config, only
ProcessesandThreadssucceed:If run in debug mode, telegraf produces this output:
The metrics are received by carbon, but it throws these 4 errors:
I see that the Graphite output serializer sanitizes the bucket name, but it doesn't sanitize the field itself, and
win_perf_countersdoesn't do any kind of sanitizing when gathering metrics.