MongoDB: Adding replication lag metric#1066
Closed
victorgp wants to merge 1 commit intoinfluxdata:masterfrom
Closed
MongoDB: Adding replication lag metric#1066victorgp wants to merge 1 commit intoinfluxdata:masterfrom
victorgp wants to merge 1 commit intoinfluxdata:masterfrom
Conversation
victorgp
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To get replication lag data i needed to obtain it from a different command "replSetGetStatus".
The code was meant to work only with a single command "serverStatus", to allow getting data from different places/commands, i changed the structure a little bit
I created a MongoStatus type that holds any other type from any other command, in this case, it has a ServerStatus object (the one that existed before) and a ReplSetStatus object, a new one that i created to store the data from "replSetGetStatus".
Using this approach, adding more metrics that come from different commands is a matter of adding the attribute to the MongoStatus type.
I tested this with a replicated setup and with a non replicated, for the non replicated it won't do anything.