Fix keyboard activation when using prefetch: 'click'#2538
Merged
pascalbaljet merged 5 commits intomasterfrom Aug 22, 2025
Merged
Fix keyboard activation when using prefetch: 'click'#2538pascalbaljet merged 5 commits intomasterfrom
prefetch: 'click'#2538pascalbaljet merged 5 commits intomasterfrom
Conversation
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keyboard activation (Enter/Space) isn't working for links using
prefetch: 'click'because the click event handler prevented default behavior but didn't trigger themousedown/mouseupevents used for prefetching and navigation. Fixes #2274.Without proper keyboard support, links become unusable for users with motor disabilities, screen reader users, and anyone who navigates with a keyboard.
I fixed this issue by adding:
keydown/keyupevent handlers to mirror the existingmousedown/mouseupbehaviorshouldActivateOnKey()to ensure Space only activates buttons (not links, per accessibility standards)