Cancel sync request on popstate event#2429
Merged
pascalbaljet merged 4 commits intomasterfrom Jul 11, 2025
Merged
Conversation
pascalbaljet
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a navigation issue that happened when a user went back in their browser history while a new page was still loading.
Previously, if a user navigated from
/page1to/page2, then clicked a link to/page3(which is slow), and immediately pressed the browser's back button,/page1would appear but the request to/page3would still be running. Once finished, it would show/page3.Now when a user goes back in history (while a new page is still loading), all pending (sync) requests are cancelled.