fix: Add missing epp_dodger compare details
#92
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulo-ferraz-oliveira
force-pushed
the
fix/post-otp28-support
branch
from
6a70150 to
305a557
Compare
paulo-ferraz-oliveira
force-pushed
the
fix/post-otp28-support
branch
from
9588b6a to
f7838ed
Compare
Collaborator
Author
|
I'm gonna test this again next to Elvis, then re-compare. |
Collaborator
Author
|
Yeah, |
Collaborator
Author
|
Yeah, recompare is ✅ next to |
Collaborator
Author
|
@elbrujohalcon, I get 
without approval. It'd be best to e.g. force at least 1 review (?) |
Member
|
Good catch, @paulo-ferraz-oliveira ! Reviews are mandatory now. |
elbrujohalcon
approved these changes
Jun 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's material for 2.4.1 😄
Don't merge yet as I work out if the changes that make the tests fail are warranted.I improved my process (and documented it in the pull request, for future reference). I locally format both files and then compare the formatted versions (even if I import stuff by hand).
There's still some stuff that's difficult to compare, even if formatted (like the stuff in this pull request - where it's all about details) but at least it's passing
elvis_core's tests.