Pagination not rendering with routerMode: History

[monibons]

If I set docsify's routerMode to history the pagination plugin fails to render. Is there a work around or fix for this?

[imyelo]

Sorry, the current version does not support this mode yet.

I opened a new branch to support it, but still need to wait for the docsify official repository to fix a minor problem.

You can follow up on the latest situation in this PR: #11

[monibons]

Great looking forward to this being supported! Thanks @imyelo

[maplion]

My Pagination was rendering and then stopped for some unknown reason and I can't get it back. I didn't set any routerMode settings, so I don't know if it is related.

[imyelo]

@maplion What is the error threw on the page?

[maplion]

There was none, it just refused to load that markdown.

…

On Mon, Jul 22, 2019, 3:12 AM yelo ***@***.***> wrote: @maplion <https://github.com/maplion> What is the error threw on the page? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#10?email_source=notifications&email_token=ACD7AMIJMMGDRWWUQGN6LRLQAV2XDA5CNFSM4GQ4OJH2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD2PJLJA#issuecomment-513709476>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ACD7AMMRZEZHW6JL5V72DHTQAV2XDANCNFSM4GQ4OJHQ> .

[trusktr]

@maplion Are you using Vue in your markdown? If so, maybe this is the issue: #16

[maplion]

Nope, no Vue. It worked initially, then stopped working and I could never get it to come back.

…

On Sat, Aug 17, 2019, 2:45 PM Joe Pea ***@***.***> wrote: @maplion <https://github.com/maplion> Are you using Vue in your markdown? If so, maybe this is the issue: #16 <#16> — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#10?email_source=notifications&email_token=ACD7AMPHGV477SL7ZNKMLDDQFCLT3A5CNFSM4GQ4OJH2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4QWCCY#issuecomment-522281227>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ACD7AMPSXFZUF5EMJISVKHTQFCLT3ANCNFSM4GQ4OJHQ> .

[rizdaprasetya]

I like this plugin and use it a lot. thanks authors, appreciate it 🎉

I also encounter the issue when Docsify set to routerMode: 'history'

I found quick (dirty) fix:
Using built script version of this plugin https://cdn.jsdelivr.net/npm/docsify-pagination@2.5.0/dist/docsify-pagination.js

Edit this line:

return decodeURIComponent(element.getAttribute('href').split('?')[0]) === decodeURIComponent('#' + path);

Replace with

return decodeURIComponent(element.getAttribute('href').split('?')[0]) === decodeURIComponent( window.$docsify.routerMode == "history" ? path : '#' + path);

The final result:
https://gist.github.com/rizdaprasetya/76704ce4d32039fd7bcd1ae2ba23e320#file-docsify-pagination-2-5-0-mod-js

It will be compatible for both routerMode: 'history' & routerMode: 'hash'
Hope it helps people who encounter same issue.

PS: I know there's PR already open addressing this issue, but it doesn't get merged yet. I'm desperately in need of the fix, so my trick above works for my needs.

[imyelo]

Fixed in #11 , and v2.6.0 released

Please feel free to reopen

[rizdaprasetya]

Wonderful, thanks for the quick resolution