Skip to content

Conversation

@YarosMallorca
Copy link
Collaborator

Description

Implements #23740

The feature must be enabled from the web interface first.

How Has This Been Tested?

  • Turn on star rating in account settings on web
  • Open mobile app
  • Go to an asset and swipe up for the detail bottom sheet
  • A star rating will appear below, click/drag on the stars to set the rating

Screenshots (if appropriate)

Screenshot_1765203211

Please describe to which degree, if any, an LLM was used in creating this pull request.

AI was not used in development.

Copy link
Member

@shenlong-tanwen shenlong-tanwen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks good to me, Will approve it after giving it another round of testing. Thanks for contributing this feature!

@R-Haecker
Copy link

Great feature, thanks you for implementing it. I hope it will get merged.
I am not too much into flutter sorry but I have small request @YarosMallorca:

I was wondering if one could increase the width or the space between the stars to fit the whole width of the bottom sheet widget. Otherwise placing it in the middle would make it a bit more accessible as well.
Just a small hint to make this feature even better.

Copy link
Member

@shenlong-tanwen shenlong-tanwen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well. The web has a clear rating button, Maybe we can add a "Clear" trailing text button or an icon button to the Rating text row, similar to the edit icons in map / description ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants