-
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
feat(mobile): star rating #24457
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat(mobile): star rating #24457
Conversation
mobile/lib/presentation/widgets/asset_viewer/bottom_sheet.widget.dart
Outdated
Show resolved
Hide resolved
mobile/lib/providers/infrastructure/user_metadata.provider.dart
Outdated
Show resolved
Hide resolved
mobile/lib/providers/infrastructure/user_metadata.provider.dart
Outdated
Show resolved
Hide resolved
mobile/lib/presentation/widgets/asset_viewer/bottom_sheet.widget.dart
Outdated
Show resolved
Hide resolved
shenlong-tanwen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change looks good to me, Will approve it after giving it another round of testing. Thanks for contributing this feature!
|
Great feature, thanks you for implementing it. I hope it will get merged. I was wondering if one could increase the width or the space between the stars to fit the whole width of the bottom sheet widget. Otherwise placing it in the middle would make it a bit more accessible as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works well. The web has a clear rating button, Maybe we can add a "Clear" trailing text button or an icon button to the Rating text row, similar to the edit icons in map / description ?
Description
Implements #23740
The feature must be enabled from the web interface first.
How Has This Been Tested?
Screenshots (if appropriate)
Please describe to which degree, if any, an LLM was used in creating this pull request.
AI was not used in development.