feat: improve asset-viewer next/prev perf and standardize preloading behavior #24422
+633
−416
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
midzelis
force-pushed
the
push-lrzkswxrukys
branch
from
2cb97c3 to
87fbf37
Compare
midzelis
changed the title
midzelis
force-pushed
the
push-lrzkswxrukys
branch
from
87fbf37 to
e34995e
Compare
midzelis
changed the title
midzelis
changed the title
midzelis
force-pushed
the
push-lrzkswxrukys
branch
from
a1be364 to
4836963
Compare
Contributor
|
Deploying preview environment to https://pr-24422.preview.internal.immich.build/ |
Comment on lines
+71
to
+84
| const getNextAsset = async (currentAsset: AssetResponseDto | undefined, preload: boolean = true) => { | ||
| if (!currentAsset) { | ||
| return; | ||
| } | ||
| const cursor = viewingAssets.indexOf(currentAsset.id); | ||
| if (cursor < viewingAssets.length - 1) { | ||
| const id = viewingAssets[cursor + 1]; | ||
| const asset = await getAssetInfo({ ...authManager.params, id }); | ||
| if (preload) { | ||
| void getNextAsset(asset, false); | ||
| } | ||
| return asset; | ||
| } | ||
| }; |
Member
There was a problem hiding this comment.
Duplicate code with large-file page. Is this intended?
Member
|
One immediate concern I have is that the usage of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A
PreloadManagerthat allows a use to preload images usingAssetResponseDtoobjects - uses same algorithm as photo-viewer.svelte (which will be replaced to use $lib/utils soon)In secure contexts, the SW will be used to preload images, and cancelation is supported. In non-secure contexts, a detached
Imageobject is used to load/cache the images, and cancelation is not supported.Stacked on #24898