feat: integrity check jobs (missing files, orphaned files, checksums) #24205
+5,392
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refactor: rename checksum_fail to checksum_mismatched
refactor: combine the stream query
chore: lint & format
feat: update summary after job runs
test: less flake
insertish
commented
Dec 19, 2025
| .select((eb) => | ||
| eb.fn | ||
| .countAll<number>() | ||
| .filterWhere('type', '=', IntegrityReportType.ChecksumFail) |
Contributor
Author
There was a problem hiding this comment.
Could do with a database index
insertish
commented
Dec 19, 2025
Comment on lines
159
to
174
| // .onRef('integrity_report.path', '=', 'allPaths.path') | ||
| ) | ||
| .select(['allPaths.path as path', 'allPaths.assetId', 'allPaths.fileAssetId', 'integrity_report.id as reportId']) | ||
| .stream(); | ||
| } | ||
|
|
||
| @GenerateSql({ params: [DummyValue.DATE, DummyValue.DATE], stream: true }) | ||
| streamAssetChecksums(startMarker?: Date, endMarker?: Date) { | ||
| return this.db | ||
| .selectFrom('asset') | ||
| .where('asset.deletedAt', 'is', null) | ||
| .leftJoin('integrity_report', (join) => | ||
| join | ||
| .onRef('integrity_report.assetId', '=', 'asset.id') | ||
| // .onRef('integrity_report.path', '=', 'asset.originalPath') | ||
| .on('integrity_report.type', '=', IntegrityReportType.ChecksumFail), |
Contributor
Author
There was a problem hiding this comment.
May want database index for assetId, fileAssetId
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR desc TODO
Description
Fixes # (issue)
How Has This Been Tested?
Screenshots (if appropriate)
Checklist:
src/services/uses repositories implementations for database calls, filesystem operations, etc.src/repositories/is pretty basic/simple and does not have any immich specific logic (that belongs insrc/services/)Please describe to which degree, if any, an LLM was used in creating this pull request.
...