feat: image editing #24155
Open
feat: image editing #24155
+7,074
−1,572
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bwees
commented
Nov 25, 2025
bwees
force-pushed
the
feat/editing
branch
4 times, most recently
from
ca37a26 to
ad14ef6
Compare
bwees
requested review from
danieldietzler and
shenlong-tanwen
as code owners
bwees
force-pushed
the
feat/editing
branch
2 times, most recently
from
a5d28ce to
6f4bacb
Compare
jrasm91
reviewed
Dec 2, 2025
bwees
force-pushed
the
feat/editing
branch
4 times, most recently
from
ba0b0ba to
c2fb6cb
Compare
Contributor
|
Deploying preview environment to https://pr-24155.preview.internal.immich.build/ |
jrasm91
reviewed
Dec 17, 2025
| thumbnailFile: getAssetFile(files, AssetFileType.Thumbnail), | ||
| sidecarFile: getAssetFile(files, AssetFileType.Sidecar), | ||
|
|
||
| editedFullsizeFile: getAssetFile(files, AssetFileType.EditedFullSize), |
Member
There was a problem hiding this comment.
I guess another convention could be something like previewFileWithEdits
bwees
commented
Dec 23, 2025
feat: db insertions for edits feat: get asset edits endpoint feat: wip apply edits feat: finish asset files changes feat: wip feat: wip fix: openapi fix: tests the failing tests were so scuffed. Simply solved by adding [] to the param list feat: more wip feat: more wip feat: some more tests and fixes chore: fix default for getting thumbnail and add todo for tests feat: LRTB validation chore: code cleanup chore: more test checks for cleanup feat: show edit pane fix: state issues chore: restructure web editor feat: restructure edit manager feat: refactor cropManager chore: combine all editing chore: web editing improvements fix: handling when no crops fix: openapi enum chore: more edit refactoring fix: make image decoding more efficient chore: more refactoring fix: getCrop LRTB algorithm fix: missing await chore: use relative coordinates for edit chore: update sql fix: use resize observer instead of svelte:doc resize hook chore: simplify quad box generation fix: light mode styling chore: refactor to not be a recursive job call this simplifies the logic and the job only completes once thumbhash and others are properly updated chore: more refactoring feat: use affine transforms for most operations feat: bounding box edit transformation feat: tests chore: sql and openapi sync fix: medium tests fix: rotated OCR chore: cleanup transform test fix: remove rebase issue fix(server): block edits for live photos, gifs, panoramic photos fix: openapi enum validation chore: rename edit endpoint chore: remove public modifiers feat: delete endpoint chore: use === and !== explicitly fix: require 1 edit for the editAsset endpoint fix: remove thumbnail edit notification and use on_upload_success instead fix: primary key on asset edit table chore: refactor to isPanorama chore: rename editRepository to assetEditRepository fix: missing toLowerCase fix: db migrations chore: update sql files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Image editing in Immich 👏 .
Supported operations:
Editing is not supported on live photos, videos, panoramas, or GIFs at this time.
How Has This Been Tested?
Screenshots (if appropriate)
Checklist:
src/services/uses repositories implementations for database calls, filesystem operations, etc.src/repositories/is pretty basic/simple and does not have any immich specific logic (that belongs insrc/services/)Please describe to which degree, if any, an LLM was used in creating this pull request.
LLM used in test case generation