-
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
feat(mobile): configurable bottom buttons in asset viewer #23635
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
fddac40 to
74f90fe
Compare
|
Motivation: in Google Photos, the asset view for shared albums includes a Like (to album activity) button in the bottom button list. While I proposed an equivalent changes, a feedback suggests the current buttons is prefered. Since feature button usage frequency and preferences vary by user, imo, making this configurable might be better approach. |
|
Would you happen to have any suggestion on the UI cue to let users know that these button position is configurable? |
|
Thank you for the appropriate confirmation. Plan A: Add a second entry point Plan B: Add a toggle in Settings: “Enable configure quick bottons” Plan B+: Alternatively, if we prioritize maintaining consistency with the current immich settings UI, it may be appropriate to change the setting to be made within the settings screen rather than using long-press. In this case, the setting will be similar to the current
|
|
Added configurable AddActionButton. #23608 |
@alextran1502 I've prototyped the above (not yet push the code chages). seems good to me. I would appreciate your feedback. screen-recording-immich-13.mp4 |
|
We can leverage your idea of a drop-down menu when clicking the kebab icon in the top-right corner of the asset viewer. I am not sure if we want to put all the buttons in the detail sheet there yet, but for now, we can have "Info" and "Configure buttons order" options in that menu. |
This reverts commit 9e2208b.
|
Thank you for your feedback. it is the approach had envisioned for Plan A. At first, based on #24175 I will PR new one that a kebabu menu containing only the info button. Temporarily, this PR reverts to draft. |
…bleGrid implementation
…h visual feedback
… visual feedback and snap animation
…d for improved drag-and-drop functionality
7a6143d to
7c3f175
Compare

Description
Remove from AlbumButton andLike (activity)Button can be configured.ScreenShotssection belowFixes # (issue)
How Has This Been Tested?
Screenshots (if appropriate)
screen-recording-immich-10.mp4
Checklist:
All code insrc/services/uses repositories implementations for database calls, filesystem operations, etc.All code insrc/repositories/is pretty basic/simple and does not have any immich specific logic (that belongs insrc/services/)Please describe to which degree, if any, an LLM was used in creating this pull request.