Skip to content

Conversation

@shenlong-tanwen
Copy link
Member

@shenlong-tanwen shenlong-tanwen commented Sep 25, 2025

Description

Fixes #21612
Fixes #20150

created_at from local_asset_entity is in local time while the one from remote_asset_entity is currently stored in UTC resulting in the asset jumping on the timeline when it is updated. This fixes it by migrating the local_asset_entity to store the datetime values in the same format as stored in the remote_asset_entity

How has this been tested

  • The new local assets are stored in the proper format
  • The old datetime values are migrated to the new format
  • Uploaded an asset and confirmed that it does not jump on the timeline

@goalie2002
Copy link
Contributor

I think this also covers #20150 (different description of the same issue)

@shenlong-tanwen shenlong-tanwen marked this pull request as draft September 25, 2025 18:50
@shenlong-tanwen
Copy link
Member Author

Drafted the PR to change the implementation. Will reopen it once the new fix is tested

@shenlong-tanwen shenlong-tanwen force-pushed the fix/merged-timeline-order branch from b563eaa to 58f217d Compare September 29, 2025 01:49
@shenlong-tanwen shenlong-tanwen force-pushed the fix/merged-timeline-order branch from 58f217d to 08ad22e Compare September 29, 2025 01:56
@shenlong-tanwen shenlong-tanwen marked this pull request as ready for review September 29, 2025 01:57
@alextran1502 alextran1502 merged commit fea5e67 into main Sep 29, 2025
52 checks passed
@alextran1502 alextran1502 deleted the fix/merged-timeline-order branch September 29, 2025 14:53
bwees pushed a commit that referenced this pull request Oct 6, 2025
* chore: refactor dateFmt to truncateDate

* fix: merged timeline orderby localtime

---------

Co-authored-by: shenlong-tanwen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[beta] asset order changes in timeline when asset is uploaded [beta] Newly created asset gets placed incorrectly in timeline

5 participants