fix: process upload only after successful remote sync #22360
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alextran1502
approved these changes
Sep 28, 2025
Member
alextran1502
left a comment
alextran1502
left a comment
There was a problem hiding this comment.
Looks good, although those .whenComplete and .then are starting to get out of hand, I think, haha. Maybe we will need a better code structure to handle these flows
Member
Author
Indeed they are. I've been thinking of having something like the Job queue on the server with pre-run / post-run hooks to simplify them. Something for later ':) |
13 tasks
bwees
pushed a commit
that referenced
this pull request
Oct 6, 2025
Co-authored-by: shenlong-tanwen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Screenshots
Indicator:
Backup page:
