Skip to content

fix(mobile): compass button overlaps status bar #22330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
alextran1502 merged 4 commits into from
Oct 2, 2025
Merged

fix(mobile): compass button overlaps status bar #22330

alextran1502 merged 4 commits into from
Oct 2, 2025

Conversation

@YarosMallorca
Copy link
Collaborator

@YarosMallorca YarosMallorca commented Sep 23, 2025 •
edited
Loading

Description

Fixes #22319

Changes

Disabled rotation and compass icon for the map, for now.

@shenlong-tanwen
Copy link
Member

shenlong-tanwen commented Sep 23, 2025

How useful is a compass on the map view? Can we just disable it instead?

@YarosMallorca
Copy link
Collaborator Author

YarosMallorca commented Sep 23, 2025 •
edited
Loading

Sure, that's also an option. Not sure why it is there in the first place...
I would prefer to have an option to disable map rotation entirely once we port the map settings sheet.

@shenlong-tanwen
Copy link
Member

shenlong-tanwen commented Sep 23, 2025 •
edited
Loading

Sure, that's also an option. Not sure why it is there in the first place

Let's just disable it. I think we just forgot disabling it since the initial release.

shenlong-tanwen
shenlong-tanwen previously requested changes Sep 25, 2025
View reviewed changes
Copy link
Member

@shenlong-tanwen shenlong-tanwen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go with disabling the compass

@aminomaboul
Copy link

aminomaboul commented Sep 26, 2025

Let's go with disabling the compass

the compass is needed to flip back the map to it's original orientation 'North-south'
it appears 'on the mobile app' only when changing map orientation

so if you remove the compass, it's necessary to disable the ability to turn the map

@YarosMallorca
Copy link
Collaborator Author

YarosMallorca commented Sep 30, 2025

@shenlong-tanwen should we disable the compass then or not? Opinions on this seem a bit conflicting...

@alextran1502 alextran1502 enabled auto-merge (squash) October 2, 2025 16:30
@alextran1502 alextran1502 merged commit 28958ba into main Oct 2, 2025
51 checks passed
@alextran1502 alextran1502 deleted the fix/compass-button branch October 2, 2025 16:35
bwees pushed a commit that referenced this pull request Oct 6, 2025
@YarosMallorca @alextran1502 @bwees
fix(mobile): compass button overlaps status bar (#22330)
813e6b1 
* fix(mobile): compass button overlaps status bar

* fix(mobile): disable rotation for map

---------

Co-authored-by: Alex <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alextran1502 alextran1502 alextran1502 approved these changes

@shenlong-tanwen shenlong-tanwen Awaiting requested review from shenlong-tanwen shenlong-tanwen is a code owner

Assignees

No one assigned

Labels

changelog:bugfix 📱mobile

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Android App: Map compass too high

5 participants

@YarosMallorca @shenlong-tanwen @aminomaboul @alextran1502