feat: add configurable backup on charging only and delay settings for android #22114
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shenlong-tanwen
commented
Sep 16, 2025
Comment on lines
+279
to
+298
| static int backupDelayToSliderValue(int ms) => switch (ms) { | ||
| 5 => 0, | ||
| 30 => 1, | ||
| 120 => 2, | ||
| _ => 3, | ||
| }; | ||
|
|
||
| static int backupDelayToSeconds(int v) => switch (v) { | ||
| 0 => 5, | ||
| 1 => 30, | ||
| 2 => 120, | ||
| _ => 600, | ||
| }; | ||
|
|
||
| static String formatBackupDelaySliderValue(int v) => switch (v) { | ||
| 0 => 'setting_notifications_notify_seconds'.tr(namedArgs: {'count': '5'}), | ||
| 1 => 'setting_notifications_notify_seconds'.tr(namedArgs: {'count': '30'}), | ||
| 2 => 'setting_notifications_notify_minutes'.tr(namedArgs: {'count': '2'}), | ||
| _ => 'setting_notifications_notify_minutes'.tr(namedArgs: {'count': '10'}), | ||
| }; |
Member
Author
There was a problem hiding this comment.
Most of the widget code were yanked from the previously implementation. These will be refactored later when the entire UI widget layer is reworked into components
alextran1502
approved these changes
Sep 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Reintroducing the previously available settings to perform backups only when charging, with a configurable initial delay on the new timeline for Android