refactor: Finish timeline migration - remove AssetGrid #22070
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove AssetGrid wrapper - Update all remaining route files to import Timeline directly - Fix component signatures where needed (onThumbnailClick → onAssetOpen) - Update album-viewer component to use Timeline - Update geolocation route with proper callback signature All routes now use Timeline component directly: - album-viewer component The major parts of the refactoring are complete.
jrasm91
previously approved these changes
Sep 16, 2025
midzelis
force-pushed
the
refactor/timeline2
branch
from
5d22649 to
cb7f573
Compare
midzelis
force-pushed
the
refactor/timeline3
branch
from
16eb9a7 to
1f66bb8
Compare
jrasm91
dismissed
their stale review
Did not realize this was a stacked PR that's built on top of another giant PR, that's likely to change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All routes and album-viewer component now use Timeline component directly
The major parts of the refactoring are complete.