chore(deps): bump flutter to 3.35.3 #22054
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mertalev
requested review from
shenlong-tanwen
and removed request for
danieldietzler
Member
|
Iirc @bwees reported that video player was broken on this flutter version. Please correct me if I misremembering |
Member
Author
|
Video playback works for me. The blocker I'm facing is that custom_lint isn't working in the CI. I think we might need to update it to 0.8.1, which then also means |
Member
This may have been related to running a mismatched flutter cli version and project sdk |
shenlong-tanwen
approved these changes
Sep 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It's possible for thumbnails to fail to load on iOS when the background worker starts running in the background. The app can attempt to process / queue tasks on the GPU when it isn't available (it isn't foreground), so the thumbnails are considered failed even when the app is opened. The new Flutter update should fix this.
Disables
custom_lintfor now as it needs a lot of dependency changes to work with the new version, which then need wider changes in the codebase. It can be re-enabled later without blocking the Flutter upgrade.How Has This Been Tested?
Tested the main timeline, asset viewer, album page and map view on an iOS release build and did not notice any anomalies. Due to the inconsistency in reproducing this scenario, I can't verify that the GPU issue is fixed.