Skip to content

Conversation

@stewx
Copy link
Contributor

@stewx stewx commented Sep 15, 2025

Description

This moves our uppercase presentation of certain text into CSS rather than the DOM.

There are calls to .toUpperCase() throughout the web codebase in the template markup, making the DOM contain uppercase text. The best practice is to use CSS for uppercase text when the reason is purely aesthetic, like in this case. Having uppercase text in the DOM is bad for accessibility.

How Has This Been Tested?

N/A

Screenshots (if appropriate)

Checklist:

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation if applicable
  • I have no unrelated changes in the PR.
  • I have confirmed that any new dependencies are strictly necessary.
  • I have written tests for new code (if applicable)
  • I have followed naming conventions/patterns in the surrounding code
  • All code in src/services/ uses repositories implementations for database calls, filesystem operations, etc.
  • All code in src/repositories/ is pretty basic/simple and does not have any immich specific logic (that belongs in src/services/)

Please describe to which degree, if any, an LLM was used in creating this pull request.

Claude Code helped make the changes.

Copy link
Member

@danieldietzler danieldietzler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! That must've been tedious 😅

@danieldietzler
Copy link
Member

Please fix the formatting issues

@stewx stewx force-pushed the bugfix/uppercase-css branch from 94b495c to 6f562c7 Compare September 15, 2025 21:05
@stewx
Copy link
Contributor Author

stewx commented Sep 15, 2025

Updated

Copy link
Member

@jrasm91 jrasm91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, now we can go through and standardize on titlecase instead of uppercase 😆

@jrasm91 jrasm91 merged commit 0f79e0c into immich-app:main Sep 16, 2025
46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants