Skip to content

chore: improve date text slide-in transition #21879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alextran1502 merged 2 commits into from
Sep 13, 2025
Merged

chore: improve date text slide-in transition #21879

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4d3e1fc
Make date text slide-in transition smooth
stewx Sep 12, 2025
b4c8db5
fix: lint
alextran1502 Sep 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions web/src/lib/components/photos-page/asset-date-group.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
import { fromTimelinePlainDate, getDateLocaleString } from '$lib/utils/timeline-util';
import type { Snippet } from 'svelte';
import { flip } from 'svelte/animate';
import { fly, scale } from 'svelte/transition';

Check warning on line 19 in web/src/lib/components/photos-page/asset-date-group.svelte

View workflow job for this annotation

GitHub Actions / Lint Web 

'fly' is defined but never used. Allowed unused vars must match /^_$/u

let { isUploading } = uploadAssetsStore;

Expand Down Expand Up @@ -169,10 +169,10 @@
class="flex pt-7 pb-5 max-md:pt-5 max-md:pb-3 h-6 place-items-center text-xs font-medium text-immich-fg dark:text-immich-dark-fg md:text-sm"
style:width={dayGroup.width + 'px'}
>
{#if !singleSelect && ((hoveredDayGroup === dayGroup.groupTitle && isMouseOverGroup) || assetInteraction.selectedGroup.has(dayGroup.groupTitle))}
{#if !singleSelect}
<div
transition:fly={{ x: -24, duration: 200, opacity: 0.5 }}
class="inline-block pe-2 hover:cursor-pointer"
class="hover:cursor-pointer transition-all duration-200 ease-out overflow-hidden w-0"
class:w-8={((hoveredDayGroup === dayGroup.groupTitle && isMouseOverGroup) || assetInteraction.selectedGroup.has(dayGroup.groupTitle))}
onclick={() => handleSelectGroup(dayGroup.groupTitle, assetsSnapshot(dayGroup.getAssets()))}
onkeydown={() => handleSelectGroup(dayGroup.groupTitle, assetsSnapshot(dayGroup.getAssets()))}
>
Expand Down
Loading