fix: context menu jank #21844
Merged
fix: context menu jank #21844
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…en transition is complete
Member
|
Oh darn, this issue has annoyed me for quite a while. I wonder if there is any native CSS's properties we can use instead of having to rely on the the transition life cycle |
Contributor
Author
|
Are you worried about performance? I can't see that being an issue with this. |
web/src/lib/components/shared-components/context-menu/context-menu.svelte
Outdated
Show resolved
Hide resolved
alextran1502
approved these changes
Sep 12, 2025
danieldietzler
approved these changes
Sep 12, 2025
Member
danieldietzler
left a comment
danieldietzler
left a comment
There was a problem hiding this comment.
I feel like this must be possible without animations but this is probably good enough for now. Thanks!
web/src/lib/components/shared-components/context-menu/context-menu.svelte
Outdated
Show resolved
Hide resolved
|
Fixes #17312 |
Co-authored-by: Alex <[email protected]>
Contributor
Author
|
I removed the comment. Should be good to go now |
jochbru
pushed a commit
to pixelunioneu/immich
that referenced
this pull request
Sep 16, 2025
* Fix issue with context menu jank by only applying overflow styling when transition is complete * Remove comment Co-authored-by: Alex <[email protected]> --------- Co-authored-by: Alex <[email protected]>
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes an issue with the context menu in which the menu has an undesired shift in width while expanding, which is caused by scrollbars displaying briefly before disappearing.
The fix is to only apply the
overflow: autoonce the CSS transition has completed.How Has This Been Tested?
Opened a photo and opened the context menu
Screenshots (if appropriate)
Before video (slowed down):
contextmenu.mp4
After video (slowed down):
contextmenuafter.mp4
Checklist:
src/services/uses repositories implementations for database calls, filesystem operations, etc.src/repositories/is pretty basic/simple and does not have any immich specific logic (that belongs insrc/services/)Please describe to which degree, if any, an LLM was used in creating this pull request.
Copilot helped