fix: android background backups #21795
Conversation
shenlong-tanwen
force-pushed
the
fix/android-bg-backups
branch
from
6ba2575 to
a8c7e5e
Compare
|
This doesn't conform with video/photo cellular requirement, correct? What happens if the server is unreachable? |
Handled both of the cases now. We make a ping to the server before starting the backup routine. If the server is not reachable, the backup is skipped. |
|
|
||
| const ServerInfoService(this._apiService); | ||
|
|
||
| Future<bool> ping() async { |
There was a problem hiding this comment.
We probably shouldn't need to ping, I am unsure of the exact logic here for the entire flow, but before any background uploads happen we should be doing a remote sync, so we can probably just use that as our "ping".
There was a problem hiding this comment.
That'd be ideal, yes! But our isolates do not propagate the errors back to the calling isolate and If we change it to do it now, I’m not entirely sure what chaos that’ll unleash elsewhere
* upload using dart client * add connectivity api * respect backup network setting * comment as to why we need to wait for setForegroundAsync call * log assets skipped due to network constraint * dynamic spawning -> false --------- Co-authored-by: shenlong-tanwen <[email protected]> Co-authored-by: Alex <[email protected]>
Fixes #21643