chore: robust isolation tasks coordination #21605
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alextran1502
added
changelog:enhancement
changelog:bugfix
and removed
changelog:skip
changelog:enhancement
labels
Member
shenlong-tanwen
left a comment
shenlong-tanwen
left a comment
There was a problem hiding this comment.
Can you also fix the static analysis?
| _ref.read(backupProvider.notifier).cancelBackup(); | ||
| final lockManager = _ref.read(isolateLockManagerProvider(kIsolateLockManagerPort)); | ||
| // Establish websocket connection first before any sync operations | ||
| debugPrint("Connecting websocket on resume"); |
Member
There was a problem hiding this comment.
Can you change the debugPrints to fine logs instead?
shenlong-tanwen
approved these changes
Sep 5, 2025
alextran1502
force-pushed
the
isolate-coordination
branch
from
79c81d9 to
3f1ab18
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.