fix(mobile): pause image loading on inactive state #21543
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
193
to
205
| void _cancelImageStream() { | ||
| final imageProvider = widget.imageProvider; | ||
| if (imageProvider is CancellableImageProvider) { | ||
| imageProvider.cancel(); | ||
| } | ||
| _stopListeningToImageStream(); | ||
| } | ||
|
|
||
| void _cancelThumbhashStream() { | ||
| final thumbhashProvider = widget.thumbhashProvider; | ||
| if (thumbhashProvider is CancellableImageProvider) { | ||
| thumbhashProvider.cancel(); | ||
| } |
Member
There was a problem hiding this comment.
I do wonder if we need separate methods for the two providers like this? Both can be upcasted to ImageProvider, then dowcast them back to CancellableImageProvider and cancel it
|
|
||
| @override | ||
| void didChangeAppLifecycleState(AppLifecycleState state) { | ||
| if (!mounted) return; |
Member
There was a problem hiding this comment.
Suggested change
| if (!mounted) return; | |
| if (!mounted) { | |
| return; | |
| } |
mertalev
force-pushed
the
fix/mobile-gpu-error
branch
from
eb70a45 to
fda8058
Compare
mertalev
changed the title
alextran1502
approved these changes
Sep 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The app continues to load images when it's inactive but not yet paused. This can lead to errors and makes it a more likely candidate to be harvested by the OS due to higher memory usage. This PR handles this by pausing image requests and resuming them when the app is active again.