Skip to content

fix: use lock to synchronise foreground and background backup #21522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
alextran1502 merged 4 commits into from
Sep 4, 2025
Merged

fix: use lock to synchronise foreground and background backup #21522

alextran1502 merged 4 commits into from
Sep 4, 2025

Conversation

@shenlong-tanwen
Copy link
Member

@shenlong-tanwen shenlong-tanwen commented Sep 2, 2025

Description

  • Uses locking mechanism to synchronize between the background (from background worker) and foreground sync process (from Main Isolate)
  • The main isolate requests the background worker to close and waits for it to close before startup and on subsequent startups from paused state
  • Before going into the paused state, the main app cancels all sync and releases the lock to let the background worker perform them

@shenlong-tanwen shenlong-tanwen force-pushed the fix/use-background-lock branch 2 times, most recently from 45bd8d1 to f664a70 Compare September 2, 2025 20:45
shenlong-tanwen and others added 3 commits September 3, 2025 20:32
@shenlong-tanwen
fix: use lock to synchronise foreground and background backup
154322e 
# Conflicts:
#	mobile/lib/domain/services/background_worker.service.dart
#	mobile/lib/platform/background_worker_api.g.dart
#	mobile/pigeon/background_worker_api.dart
@shenlong-tanwen
add timeout to the splash-screen acquire lock
62a70f6
@alextran1502 @shenlong-tanwen
fix: null check on created date
17f1f25
@alextran1502 alextran1502 merged commit 5fe954b into main Sep 4, 2025
49 checks passed
@alextran1502 alextran1502 deleted the fix/use-background-lock branch September 4, 2025 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alextran1502 alextran1502 alextran1502 approved these changes

Assignees

No one assigned

Labels

changelog:bugfix 📱mobile

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@shenlong-tanwen @alextran1502