fix(server): use GPSLongitudeRef and GPSLatitudeRef EXIF fields #21445
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
ruippeixotog
force-pushed
the
geolocation-fix
branch
from
766cafe to
edb5704
Compare
ruippeixotog
changed the title
Contributor
Author
|
@danieldietzler, could you please approve the tests so I can confirm everything works as expected in CI? |
Member
|
Done @ruippeixotog. Also, there are merge conflicts now :/ |
ruippeixotog
force-pushed
the
geolocation-fix
branch
from
edb5704 to
3937ea5
Compare
Contributor
Author
|
@danieldietzler merge conflicts fixed, tests are ready to run again 👍 One question, how flaky are e2e tests usually? The two times tests ran on my PR (first, second) the job failed with a different unit test failing, but I didn't do anything other than rebasing my code on top of the latest main. In both cases I analyzed the tests and I don't think they're related to my changes. |
Member
|
Unfortunately e2e tests are a bit flaky, usually a single re-run should fix them though |
ruippeixotog
force-pushed
the
geolocation-fix
branch
from
3937ea5 to
f740084
Compare
Contributor
Author
|
exiftool/exiftool#348 was closed and a new version was released, which means we might not need the re-encoding hack anymore. This PR is now just bumping exiftool-vendored's version and enabling geolocation. |
Contributor
Author
|
@danieldietzler, sorry for the inconvenience, but do you mind running the tests again? The PR was updated to be much simpler now, so there should be little reason for tests breaking now. |
danieldietzler
approved these changes
Oct 4, 2025
Member
danieldietzler
left a comment
danieldietzler
left a comment
There was a problem hiding this comment.
This also looks good to go for me as is. However we're currently holding off from upgrading any npm packages given the recent supply chain attacks, so we will likely keep this PR around for another week or so :)
Contributor
Author
|
Hey @danieldietzler, any news on this PR? Will we be able to merge and publish a new version with this fix soon? |
ruippeixotog
force-pushed
the
geolocation-fix
branch
from
f740084 to
99ae3f7
Compare
Member
|
Yeah we're back to updating packages again and I just read through the release notes and that seems fine. If you got the build fixed we can merge this :) |
Contributor
Author
|
Great! I just noticed new TS errors showed up after I rebased this PR, please approve the build again :) |
1 task
Member
|
Sorry for some reason I didn't see the github notification and just now got to it again. Just took the liberty to clean fix this up myself. Thanks for working on this PR! |
danieldietzler
force-pushed
the
geolocation-fix
branch
from
aef24de to
ea81fba
Compare
danieldietzler
force-pushed
the
geolocation-fix
branch
from
ea81fba to
8ef47ab
Compare
Contributor
Author
|
@danieldietzler, thanks for all the help with the PR! Just so I know what to expect: when do you believe an Immich version with this fix will be released? |
Member
|
We don't give ETAs for releases. Given we haven't had a release in a bit you can expect one soon(tm) though ;) |
Contributor
Author
|
Sounds good, will check regularly then! |
alexlebens
pushed a commit
to alexlebens/infrastructure
that referenced
this pull request
Oct 31, 2025
This PR contains the following updates: | Package | Update | Change | |---|---|---| | [ghcr.io/immich-app/immich-server](https://github.com/immich-app/immich) | minor | `v2.1.0` -> `v2.2.1` | --- ### Release Notes <details> <summary>immich-app/immich (ghcr.io/immich-app/immich-server)</summary> ### [`v2.2.1`](https://github.com/immich-app/immich/releases/tag/v2.2.1) [Compare Source](immich-app/immich@v2.2.0...v2.2.1) <!-- Release notes generated using configuration in .github/release.yml at v2.2.1 --> #### What's Changed ##### 🐛 Bug fixes - fix(mobile): regression - not displayed activity button in top bar by [@​idubnori](https://github.com/idubnori) in [#​23366](immich-app/immich#23366) - fix: asset copy validation error by [@​danieldietzler](https://github.com/danieldietzler) in [#​23387](immich-app/immich#23387) - fix(ml): ocr failing with rootless docker by [@​mertalev](https://github.com/mertalev) in [#​23402](immich-app/immich#23402) - fix(mobile): video seeking on android by [@​mertalev](https://github.com/mertalev) in [#​23405](immich-app/immich#23405) - fix: button condition rendering by [@​alextran1502](https://github.com/alextran1502) in [#​23400](immich-app/immich#23400) - fix: view in timeline does not jump to the timeline correctly by [@​alextran1502](https://github.com/alextran1502) in [#​23428](immich-app/immich#23428) - fix: show close button on purchase modal by [@​alextran1502](https://github.com/alextran1502) in [#​23436](immich-app/immich#23436) ##### 📚 Documentation - chore: update android signing fingerprints to docs by [@​luneth](https://github.com/luneth) in [#​23361](immich-app/immich#23361) ##### 🌐 Translations - chore(web): update translations by [@​weblate](https://github.com/weblate) in [#​23375](immich-app/immich#23375) #### New Contributors - [@​luneth](https://github.com/luneth) made their first contribution in [#​23361](immich-app/immich#23361) **Full Changelog**: <immich-app/immich@v2.2.0...v2.2.1> ### [`v2.2.0`](https://github.com/immich-app/immich/releases/tag/v2.2.0) [Compare Source](immich-app/immich@v2.1.0...v2.2.0) ### v2.2.0 *The month following our [stable release ](https://immich.app/blog/stable-release)**🎉** has flown by! We are blown away by the support from everyone around this milestone, especially for the [Retro DVD ](https://immich.store/products/immich-retro)**📀**! If you want to get one for yourself, you still can, but once this batch is gone, we won’t be making any more, **EVER!** So get one while you can from [immich.store](https://immich.store/)!* <img width="2292" height="209" alt="image" src="https://github.com/user-attachments/assets/3829caef-8674-4ab0-a0d0-954c317e8987" /> #### Highlights Welcome to version `v2.2.0` of Immich. This release comes with the traditional Immich fashion, where the features and enhancements list is longer than the bug fixes list. Let’s dive right into the highlights of this exciting release - New mutable Docker tag for `v2` versions - Optical Character Recognition (OCR) - \[Web] Wasm implementation for justified layout calculation 🦀 - \[Web] UI improvement for the review duplicates screen - \[Mobile] Show albums in the asset’s detail sheet - \[Mobile] Show similar photos - \[Mobile] Chat-style for activity view - \[Mobile] High precision seeking for video - \[Mobile] New UI to present server-client version mismatch - Option to create a new user as an admin - Notable fix: older iOS devices freeze when spawning background tasks - Notable fix: temporary files on iOS are now cleaned up properly ##### Docker tag for `v2` versions The `example.env` file has been updated to use `IMMICH_VERSION=v2`, which is a mutable Docker tag that points to the latest `2.x.x` release image. ##### Optical Character Recognition (OCR) OCR search has been one of the most requested features on our users' wishlists. Thanks to the fantastic work of [@​flipped-1121](https://github.com/flipped-1121) and [@​mertalev](https://github.com/mertalev), Immich can now recognize texts in images, adding a powerful capability to its already powerful search features. This will help users find lost family recipes or a crypto wallet’s passphrase more easily. The OCR pipeline is integrated into the existing machine learning flow. For new uploads, it will run automatically with the existing machine learning flow. For existing setups, you can go to `Administration > Job > Click on “All” for OCR job` to extract OCR information for your gallery <p align="center"> <img width="800" alt="image" src="https://github.com/user-attachments/assets/ece151cf-4268-406a-a68f-ce3c9c869c15" /> </p> To search for letters in photos, a new radio button has been added to the search type on the web app, and in the dropdown list on the mobile app. <p align="center"> <img width="500" alt="image" src="https://github.com/user-attachments/assets/adb161c8-717d-4030-b5eb-4f3cfef11a96" /> </p> OCR currently has official support for English, Chinese (Simplified), Chinese (Traditional) and Japanese text. Languages using Latin script generally work as well, but may have lower accuracy or interpret characters without the diacritics. ##### \[Web] Wasm implementation for justified layout calculation 🦀 This release comes with a blazing-fast re-implementation of the justified layout on the web, which makes calculating the size of the thumbnails in each bucket several times faster, significantly improving the rendering performance for a large bucket, i.e., 10s of thousands of assets in a single month ##### \[Web] UI improvement for the review duplicates screen To help you decide which asset to keep in a group of duplicates, more information has been added to the info section below each asset, including date/time, location, and the number of albums the asset is in. The info section has been redesigned to make scanning the information faster, with different properties getting highlighted. We will keep improving on this interface to make it more intuitive <p align="center"> <img width="800" alt="image" src="https://github.com/user-attachments/assets/0bee8443-b44e-4264-a4ab-36a99cef4596" /> </p> ##### \[Mobile\] Show albums in the asset’s detail You can view and navigate to the albums that the asset belongs to in the info sheet <p align="center"> <img width="300" alt="image" src="https://github.com/user-attachments/assets/96bb194a-cc54-478b-9958-b6e8eea9b03c" /> </p> ##### \[Mobile\] Show similar photos The popular feature “Show similar photos” has made its way to the mobile app. You can use the button in the detail sheet to find similar images to the one you are viewing. <p align="center"> <img width="300" alt="image" src="https://github.com/user-attachments/assets/45cb751d-da22-4fe8-bc47-406dbb9c9cfc" /> </p> ##### \[Mobile\] Chat-style for album activity view The album’s activity view now displays the messages and actions in a chat-style view, making it easier to follow <p align="center"> <img width="300" alt="image" src="https://github.com/user-attachments/assets/a5a8a4aa-ebbe-4282-844b-27e9df14a529" /> </p> ##### \[Mobile\] High precision seeking for video The progress bar of the video player now has higher precision duration handling. This makes seeking much more fluid than before, as well as making position updates in the progress bar smooth, rather than jumping from second to second. ##### \[Mobile] New UI to present server-client version mismatch As we are now in the stable-era, we want to make the notification of a new version more subtle, less distracting. The update message and icon’s color on the mobile app have been redesigned for that purpose. When your server version is older than the available one, a message with a clickable link is displayed, directing you to the latest release notes. When your mobile app version is older than the one available on the App Store, a message with a clickable link appears, directing you to the App Store to perform the update. | Server update | App update | | --------------------------------------------------------------------------------------------------------------------- | ----------------------------------------------------------------------------------------------------------------------------------- | | <img width="300" alt="image" src="https://github.com/user-attachments/assets/c136aab6-ef39-4769-ab35-b6719b188ed5" /> | <img width="300" height="2340" alt="image" src="https://github.com/user-attachments/assets/3bead2e2-f202-48b8-9164-c5c29c999434" /> | #### Support Immich <p align="center"> <img src="https://media.giphy.com/media/v1.Y2lkPTc5MGI3NjExbjY2eWc5Y2F0ZW56MmR4aWE0dDhzZXlidXRmYWZyajl1bWZidXZpcyZlcD12MV9pbnRlcm5hbF9naWZfYnlfaWQmY3Q9Zw/87CKDqErVfMqY/giphy.gif" width="450" title="SUPPORT THE PROJECT!"> </p> If you find the project helpful, you can support Immich by purchasing a product key at <https://buy.immich.app> or our merchandise at <https://immich.store> <!-- Release notes generated using configuration in .github/release.yml at main --> #### What's Changed ##### 🔒 Security - fix(server): bump valkey to 8 by [@​mmomjian](https://github.com/mmomjian) in [#​22911](immich-app/immich#22911) ##### 🚀 Features - feat(ml): coreml by [@​mertalev](https://github.com/mertalev) in [#​17718](immich-app/immich#17718) - feat(server): Option to configure SMTPS transport by [@​clementmartin](https://github.com/clementmartin) in [#​22833](immich-app/immich#22833) - feat: show location & date on duplicate asset comparison overview by [@​adrianjost](https://github.com/adrianjost) in [#​22632](immich-app/immich#22632) - feat: view the user's app version on the user page by [@​aviv926](https://github.com/aviv926) in [#​21345](immich-app/immich#21345) - feat: GHA for iOS release flow by [@​alextran1502](https://github.com/alextran1502) in [#​23196](immich-app/immich#23196) - feat(web): add search filter for camera lens model. by [@​dagstuan](https://github.com/dagstuan) in [#​21792](immich-app/immich#21792) - feat(web): load original videos by [@​andre-antunesdesa](https://github.com/andre-antunesdesa) in [#​20041](immich-app/immich#20041) - feat(cli): add --delete-duplicates option by [@​RobinJ1995](https://github.com/RobinJ1995) in [#​20035](immich-app/immich#20035) - feat: ocr by [@​flipped-1121](https://github.com/flipped-1121) in [#​18836](immich-app/immich#18836) - feat: show "appears in" albums on asset viewer bottom sheet by [@​bwees](https://github.com/bwees) in [#​21925](immich-app/immich#21925) - feat: getAssetOcr endpoint by [@​alextran1502](https://github.com/alextran1502) in [#​23331](immich-app/immich#23331) - feat(mobile): view similar photos by [@​vitoksmile](https://github.com/vitoksmile) in [#​22148](immich-app/immich#22148) - feat(mobile): chat-style album activities timeline by [@​idubnori](https://github.com/idubnori) in [#​23185](immich-app/immich#23185) ##### 🌟 Enhancements - feat(album): show per-user contributions in shared albums by [@​Chaoscontrol](https://github.com/Chaoscontrol) in [#​21740](immich-app/immich#21740) - feat: add video auto play setting by [@​Saschl](https://github.com/Saschl) in [#​20416](immich-app/immich#20416) - fix(web): improve scrubber behavior on scroll-limited timelines by [@​midzelis](https://github.com/midzelis) in [#​22917](immich-app/immich#22917) - feat(web): Download links and Obtainium link generator on Utilities page and onboarding by [@​NicholasFlamy](https://github.com/NicholasFlamy) in [#​20589](immich-app/immich#20589) - feat(web): create user as admin by [@​jrasm91](https://github.com/jrasm91) in [#​23026](immich-app/immich#23026) - chore: rework backup success notification descriptions by [@​bwees](https://github.com/bwees) in [#​23024](immich-app/immich#23024) - feat(mobile): Change the UI of asset activity list to bottom sheet by [@​idubnori](https://github.com/idubnori) in [#​23075](immich-app/immich#23075) - feat: improved update messaging on app bar server info by [@​bwees](https://github.com/bwees) in [#​22938](immich-app/immich#22938) - refactor(web): improve date labels in scrubber by [@​midzelis](https://github.com/midzelis) in [#​23046](immich-app/immich#23046) - feat: support database dumps for pg18 by [@​zackpollard](https://github.com/zackpollard) in [#​23186](immich-app/immich#23186) - feat: improvements of thumbnail animations by [@​Lauritz-Tieste](https://github.com/Lauritz-Tieste) in [#​20300](immich-app/immich#20300) - feat(web): reactively update shared link expiration by [@​khanbasharat3a1](https://github.com/khanbasharat3a1) in [#​22274](immich-app/immich#22274) - feat: (mobile) open asset viewer from album activity page by [@​idubnori](https://github.com/idubnori) in [#​23182](immich-app/immich#23182) - feat(mobile): high precision seeking by [@​mertalev](https://github.com/mertalev) in [#​22346](immich-app/immich#22346) - feat(web): wasm justified layout, sync edition by [@​mertalev](https://github.com/mertalev) in [#​23194](immich-app/immich#23194) - feat: logout sessions on password change by [@​MontejoJorge](https://github.com/MontejoJorge) in [#​23188](immich-app/immich#23188) - feat(server): enhance metadata reading for video files by [@​tstachl](https://github.com/tstachl) in [#​23258](immich-app/immich#23258) - feat: improve UI for resolving duplication detection by [@​alextran1502](https://github.com/alextran1502) in [#​23145](immich-app/immich#23145) - feat: toasts by [@​jrasm91](https://github.com/jrasm91) in [#​23298](immich-app/immich#23298) - feat: asset copy by [@​danieldietzler](https://github.com/danieldietzler) in [#​23172](immich-app/immich#23172) ##### 🐛 Bug fixes - fix(web): prevent photo-only memories showing mute button by [@​meesfrensel](https://github.com/meesfrensel) in [#​22802](immich-app/immich#22802) - fix: get all assets for the Recents album on iOS by [@​alextran1502](https://github.com/alextran1502) in [#​22956](immich-app/immich#22956) - fix: tag clean up query and add tests by [@​MontejoJorge](https://github.com/MontejoJorge) in [#​22633](immich-app/immich#22633) - fix: unit overlapses value in server stats card by [@​alextran1502](https://github.com/alextran1502) in [#​22994](immich-app/immich#22994) - fix: navigate to time action by [@​midzelis](https://github.com/midzelis) in [#​20928](immich-app/immich#20928) - fix: remove assets from shared link by [@​MontejoJorge](https://github.com/MontejoJorge) in [#​22935](immich-app/immich#22935) - fix(server): only asset owner should see favorite status by [@​pwojtaszko](https://github.com/pwojtaszko) in [#​20654](immich-app/immich#20654) - fix(web): render context overlays over the scrollbar by [@​PaulSonOfLars](https://github.com/PaulSonOfLars) in [#​23007](immich-app/immich#23007) - fix(web): two scrollbars in folder view by [@​YarosMallorca](https://github.com/YarosMallorca) in [#​23045](immich-app/immich#23045) - fix: skip ML availability check if ML is disabled by [@​bo0tzz](https://github.com/bo0tzz) in [#​23053](immich-app/immich#23053) - chore: skip dialog for single merged asset by [@​shenlong-tanwen](https://github.com/shenlong-tanwen) in [#​22958](immich-app/immich#22958) - fix(mobile): notate experimental network features, cleanup mis assigned translation tags by [@​mmomjian](https://github.com/mmomjian) in [#​23021](immich-app/immich#23021) - fix(ml): pin cudnn version by [@​mertalev](https://github.com/mertalev) in [#​23110](immich-app/immich#23110) - fix(server): use GPSLongitudeRef and GPSLatitudeRef EXIF fields by [@​ruippeixotog](https://github.com/ruippeixotog) in [#​21445](immich-app/immich#21445) - fix: allow editing all images by [@​bwees](https://github.com/bwees) in [#​23144](immich-app/immich#23144) - fix: isolate freeze app on older ios device by [@​alextran1502](https://github.com/alextran1502) in [#​22509](immich-app/immich#22509) - fix: android skip posting hash response after detached from engine by [@​shenlong-tanwen](https://github.com/shenlong-tanwen) in [#​23192](immich-app/immich#23192) - fix: back/forward navigation won't reset scroll in timeline by [@​midzelis](https://github.com/midzelis) in [#​22838](immich-app/immich#22838) - fix: handle null bucketId or name in android local sync by [@​shenlong-tanwen](https://github.com/shenlong-tanwen) in [#​23224](immich-app/immich#23224) - fix: fetch original name before upload by [@​shenlong-tanwen](https://github.com/shenlong-tanwen) in [#​21877](immich-app/immich#21877) - fix: focus-trap on safari by [@​midzelis](https://github.com/midzelis) in [#​23246](immich-app/immich#23246) - fix(web): disable picture-in-picture on video viewer by [@​tstachl](https://github.com/tstachl) in [#​23318](immich-app/immich#23318) - fix: make hitbox on app bar dialog bigger by [@​bwees](https://github.com/bwees) in [#​23316](immich-app/immich#23316) - fix: clear temp cache on iOS before uploads by [@​shenlong-tanwen](https://github.com/shenlong-tanwen) in [#​23326](immich-app/immich#23326) ##### 📚 Documentation - fix(web): clarify some transcoding settings by [@​meesfrensel](https://github.com/meesfrensel) in [#​22797](immich-app/immich#22797) - docs: fix small error by [@​0xflotus](https://github.com/0xflotus) in [#​22890](immich-app/immich#22890) - docs: Expand on OpenVINO WSL HW accel by [@​Mraedis](https://github.com/Mraedis) in [#​21054](immich-app/immich#21054) - docs: clarify well-known usage by [@​jrasm91](https://github.com/jrasm91) in [#​23018](immich-app/immich#23018) - feat: move community projects and guides to immich-aweseome by [@​jrasm91](https://github.com/jrasm91) in [#​23016](immich-app/immich#23016) - fix(docs): cli upload json format example by [@​leepeuker](https://github.com/leepeuker) in [#​22858](immich-app/immich#22858) - docs: update [backup-and-restore.md](http://backup-and-restore.md) by [@​nickwebcouk](https://github.com/nickwebcouk) in [#​21065](immich-app/immich#21065) #### New Contributors - [@​Chaoscontrol](https://github.com/Chaoscontrol) made their first contribution in [#​21740](immich-app/immich#21740) - [@​meesfrensel](https://github.com/meesfrensel) made their first contribution in [#​22802](immich-app/immich#22802) - [@​0xflotus](https://github.com/0xflotus) made their first contribution in [#​22890](immich-app/immich#22890) - [@​clementmartin](https://github.com/clementmartin) made their first contribution in [#​22833](immich-app/immich#22833) - [@​leepeuker](https://github.com/leepeuker) made their first contribution in [#​22858](immich-app/immich#22858) - [@​nickwebcouk](https://github.com/nickwebcouk) made their first contribution in [#​21065](immich-app/immich#21065) - [@​idubnori](https://github.com/idubnori) made their first contribution in [#​23075](immich-app/immich#23075) - [@​ruippeixotog](https://github.com/ruippeixotog) made their first contribution in [#​21445](immich-app/immich#21445) - [@​Nykri](https://github.com/Nykri) made their first contribution in [#​22888](immich-app/immich#22888) - [@​slagiewka](https://github.com/slagiewka) made their first contribution in [#​23130](immich-app/immich#23130) - [@​khanbasharat3a1](https://github.com/khanbasharat3a1) made their first contribution in [#​22274](immich-app/immich#22274) - [@​andre-antunesdesa](https://github.com/andre-antunesdesa) made their first contribution in [#​20041](immich-app/immich#20041) - [@​RobinJ1995](https://github.com/RobinJ1995) made their first contribution in [#​20035](immich-app/immich#20035) - [@​flipped-1121](https://github.com/flipped-1121) made their first contribution in [#​18836](immich-app/immich#18836) - [@​ZacWarham](https://github.com/ZacWarham) made their first contribution in [#​23275](immich-app/immich#23275) - [@​tstachl](https://github.com/tstachl) made their first contribution in [#​23258](immich-app/immich#23258) **Full Changelog**: <immich-app/immich@v2.1.0...v2.2.0> </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0MS4xNTUuNCIsInVwZGF0ZWRJblZlciI6IjQxLjE1NS41IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJpbWFnZSJdfQ==--> Reviewed-on: https://gitea.alexlebens.dev/alexlebens/infrastructure/pulls/1905 Co-authored-by: Renovate Bot <[email protected]> Co-committed-by: Renovate Bot <[email protected]>
alexlebens
pushed a commit
to alexlebens/infrastructure
that referenced
this pull request
Oct 31, 2025
…1 (#1904) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [ghcr.io/immich-app/immich-machine-learning](https://github.com/immich-app/immich) | minor | `v2.1.0` -> `v2.2.1` | --- ### Release Notes <details> <summary>immich-app/immich (ghcr.io/immich-app/immich-machine-learning)</summary> ### [`v2.2.1`](https://github.com/immich-app/immich/releases/tag/v2.2.1) [Compare Source](immich-app/immich@v2.2.0...v2.2.1) <!-- Release notes generated using configuration in .github/release.yml at v2.2.1 --> #### What's Changed ##### 🐛 Bug fixes - fix(mobile): regression - not displayed activity button in top bar by [@​idubnori](https://github.com/idubnori) in [#​23366](immich-app/immich#23366) - fix: asset copy validation error by [@​danieldietzler](https://github.com/danieldietzler) in [#​23387](immich-app/immich#23387) - fix(ml): ocr failing with rootless docker by [@​mertalev](https://github.com/mertalev) in [#​23402](immich-app/immich#23402) - fix(mobile): video seeking on android by [@​mertalev](https://github.com/mertalev) in [#​23405](immich-app/immich#23405) - fix: button condition rendering by [@​alextran1502](https://github.com/alextran1502) in [#​23400](immich-app/immich#23400) - fix: view in timeline does not jump to the timeline correctly by [@​alextran1502](https://github.com/alextran1502) in [#​23428](immich-app/immich#23428) - fix: show close button on purchase modal by [@​alextran1502](https://github.com/alextran1502) in [#​23436](immich-app/immich#23436) ##### 📚 Documentation - chore: update android signing fingerprints to docs by [@​luneth](https://github.com/luneth) in [#​23361](immich-app/immich#23361) ##### 🌐 Translations - chore(web): update translations by [@​weblate](https://github.com/weblate) in [#​23375](immich-app/immich#23375) #### New Contributors - [@​luneth](https://github.com/luneth) made their first contribution in [#​23361](immich-app/immich#23361) **Full Changelog**: <immich-app/immich@v2.2.0...v2.2.1> ### [`v2.2.0`](https://github.com/immich-app/immich/releases/tag/v2.2.0) [Compare Source](immich-app/immich@v2.1.0...v2.2.0) ### v2.2.0 *The month following our [stable release ](https://immich.app/blog/stable-release)**🎉** has flown by! We are blown away by the support from everyone around this milestone, especially for the [Retro DVD ](https://immich.store/products/immich-retro)**📀**! If you want to get one for yourself, you still can, but once this batch is gone, we won’t be making any more, **EVER!** So get one while you can from [immich.store](https://immich.store/)!* <img width="2292" height="209" alt="image" src="https://github.com/user-attachments/assets/3829caef-8674-4ab0-a0d0-954c317e8987" /> #### Highlights Welcome to version `v2.2.0` of Immich. This release comes with the traditional Immich fashion, where the features and enhancements list is longer than the bug fixes list. Let’s dive right into the highlights of this exciting release - New mutable Docker tag for `v2` versions - Optical Character Recognition (OCR) - \[Web] Wasm implementation for justified layout calculation 🦀 - \[Web] UI improvement for the review duplicates screen - \[Mobile] Show albums in the asset’s detail sheet - \[Mobile] Show similar photos - \[Mobile] Chat-style for activity view - \[Mobile] High precision seeking for video - \[Mobile] New UI to present server-client version mismatch - Option to create a new user as an admin - Notable fix: older iOS devices freeze when spawning background tasks - Notable fix: temporary files on iOS are now cleaned up properly ##### Docker tag for `v2` versions The `example.env` file has been updated to use `IMMICH_VERSION=v2`, which is a mutable Docker tag that points to the latest `2.x.x` release image. ##### Optical Character Recognition (OCR) OCR search has been one of the most requested features on our users' wishlists. Thanks to the fantastic work of [@​flipped-1121](https://github.com/flipped-1121) and [@​mertalev](https://github.com/mertalev), Immich can now recognize texts in images, adding a powerful capability to its already powerful search features. This will help users find lost family recipes or a crypto wallet’s passphrase more easily. The OCR pipeline is integrated into the existing machine learning flow. For new uploads, it will run automatically with the existing machine learning flow. For existing setups, you can go to `Administration > Job > Click on “All” for OCR job` to extract OCR information for your gallery <p align="center"> <img width="800" alt="image" src="https://github.com/user-attachments/assets/ece151cf-4268-406a-a68f-ce3c9c869c15" /> </p> To search for letters in photos, a new radio button has been added to the search type on the web app, and in the dropdown list on the mobile app. <p align="center"> <img width="500" alt="image" src="https://github.com/user-attachments/assets/adb161c8-717d-4030-b5eb-4f3cfef11a96" /> </p> OCR currently has official support for English, Chinese (Simplified), Chinese (Traditional) and Japanese text. Languages using Latin script generally work as well, but may have lower accuracy or interpret characters without the diacritics. ##### \[Web] Wasm implementation for justified layout calculation 🦀 This release comes with a blazing-fast re-implementation of the justified layout on the web, which makes calculating the size of the thumbnails in each bucket several times faster, significantly improving the rendering performance for a large bucket, i.e., 10s of thousands of assets in a single month ##### \[Web] UI improvement for the review duplicates screen To help you decide which asset to keep in a group of duplicates, more information has been added to the info section below each asset, including date/time, location, and the number of albums the asset is in. The info section has been redesigned to make scanning the information faster, with different properties getting highlighted. We will keep improving on this interface to make it more intuitive <p align="center"> <img width="800" alt="image" src="https://github.com/user-attachments/assets/0bee8443-b44e-4264-a4ab-36a99cef4596" /> </p> ##### \[Mobile\] Show albums in the asset’s detail You can view and navigate to the albums that the asset belongs to in the info sheet <p align="center"> <img width="300" alt="image" src="https://github.com/user-attachments/assets/96bb194a-cc54-478b-9958-b6e8eea9b03c" /> </p> ##### \[Mobile\] Show similar photos The popular feature “Show similar photos” has made its way to the mobile app. You can use the button in the detail sheet to find similar images to the one you are viewing. <p align="center"> <img width="300" alt="image" src="https://github.com/user-attachments/assets/45cb751d-da22-4fe8-bc47-406dbb9c9cfc" /> </p> ##### \[Mobile\] Chat-style for album activity view The album’s activity view now displays the messages and actions in a chat-style view, making it easier to follow <p align="center"> <img width="300" alt="image" src="https://github.com/user-attachments/assets/a5a8a4aa-ebbe-4282-844b-27e9df14a529" /> </p> ##### \[Mobile\] High precision seeking for video The progress bar of the video player now has higher precision duration handling. This makes seeking much more fluid than before, as well as making position updates in the progress bar smooth, rather than jumping from second to second. ##### \[Mobile] New UI to present server-client version mismatch As we are now in the stable-era, we want to make the notification of a new version more subtle, less distracting. The update message and icon’s color on the mobile app have been redesigned for that purpose. When your server version is older than the available one, a message with a clickable link is displayed, directing you to the latest release notes. When your mobile app version is older than the one available on the App Store, a message with a clickable link appears, directing you to the App Store to perform the update. | Server update | App update | | --------------------------------------------------------------------------------------------------------------------- | ----------------------------------------------------------------------------------------------------------------------------------- | | <img width="300" alt="image" src="https://github.com/user-attachments/assets/c136aab6-ef39-4769-ab35-b6719b188ed5" /> | <img width="300" height="2340" alt="image" src="https://github.com/user-attachments/assets/3bead2e2-f202-48b8-9164-c5c29c999434" /> | #### Support Immich <p align="center"> <img src="https://media.giphy.com/media/v1.Y2lkPTc5MGI3NjExbjY2eWc5Y2F0ZW56MmR4aWE0dDhzZXlidXRmYWZyajl1bWZidXZpcyZlcD12MV9pbnRlcm5hbF9naWZfYnlfaWQmY3Q9Zw/87CKDqErVfMqY/giphy.gif" width="450" title="SUPPORT THE PROJECT!"> </p> If you find the project helpful, you can support Immich by purchasing a product key at <https://buy.immich.app> or our merchandise at <https://immich.store> <!-- Release notes generated using configuration in .github/release.yml at main --> #### What's Changed ##### 🔒 Security - fix(server): bump valkey to 8 by [@​mmomjian](https://github.com/mmomjian) in [#​22911](immich-app/immich#22911) ##### 🚀 Features - feat(ml): coreml by [@​mertalev](https://github.com/mertalev) in [#​17718](immich-app/immich#17718) - feat(server): Option to configure SMTPS transport by [@​clementmartin](https://github.com/clementmartin) in [#​22833](immich-app/immich#22833) - feat: show location & date on duplicate asset comparison overview by [@​adrianjost](https://github.com/adrianjost) in [#​22632](immich-app/immich#22632) - feat: view the user's app version on the user page by [@​aviv926](https://github.com/aviv926) in [#​21345](immich-app/immich#21345) - feat: GHA for iOS release flow by [@​alextran1502](https://github.com/alextran1502) in [#​23196](immich-app/immich#23196) - feat(web): add search filter for camera lens model. by [@​dagstuan](https://github.com/dagstuan) in [#​21792](immich-app/immich#21792) - feat(web): load original videos by [@​andre-antunesdesa](https://github.com/andre-antunesdesa) in [#​20041](immich-app/immich#20041) - feat(cli): add --delete-duplicates option by [@​RobinJ1995](https://github.com/RobinJ1995) in [#​20035](immich-app/immich#20035) - feat: ocr by [@​flipped-1121](https://github.com/flipped-1121) in [#​18836](immich-app/immich#18836) - feat: show "appears in" albums on asset viewer bottom sheet by [@​bwees](https://github.com/bwees) in [#​21925](immich-app/immich#21925) - feat: getAssetOcr endpoint by [@​alextran1502](https://github.com/alextran1502) in [#​23331](immich-app/immich#23331) - feat(mobile): view similar photos by [@​vitoksmile](https://github.com/vitoksmile) in [#​22148](immich-app/immich#22148) - feat(mobile): chat-style album activities timeline by [@​idubnori](https://github.com/idubnori) in [#​23185](immich-app/immich#23185) ##### 🌟 Enhancements - feat(album): show per-user contributions in shared albums by [@​Chaoscontrol](https://github.com/Chaoscontrol) in [#​21740](immich-app/immich#21740) - feat: add video auto play setting by [@​Saschl](https://github.com/Saschl) in [#​20416](immich-app/immich#20416) - fix(web): improve scrubber behavior on scroll-limited timelines by [@​midzelis](https://github.com/midzelis) in [#​22917](immich-app/immich#22917) - feat(web): Download links and Obtainium link generator on Utilities page and onboarding by [@​NicholasFlamy](https://github.com/NicholasFlamy) in [#​20589](immich-app/immich#20589) - feat(web): create user as admin by [@​jrasm91](https://github.com/jrasm91) in [#​23026](immich-app/immich#23026) - chore: rework backup success notification descriptions by [@​bwees](https://github.com/bwees) in [#​23024](immich-app/immich#23024) - feat(mobile): Change the UI of asset activity list to bottom sheet by [@​idubnori](https://github.com/idubnori) in [#​23075](immich-app/immich#23075) - feat: improved update messaging on app bar server info by [@​bwees](https://github.com/bwees) in [#​22938](immich-app/immich#22938) - refactor(web): improve date labels in scrubber by [@​midzelis](https://github.com/midzelis) in [#​23046](immich-app/immich#23046) - feat: support database dumps for pg18 by [@​zackpollard](https://github.com/zackpollard) in [#​23186](immich-app/immich#23186) - feat: improvements of thumbnail animations by [@​Lauritz-Tieste](https://github.com/Lauritz-Tieste) in [#​20300](immich-app/immich#20300) - feat(web): reactively update shared link expiration by [@​khanbasharat3a1](https://github.com/khanbasharat3a1) in [#​22274](immich-app/immich#22274) - feat: (mobile) open asset viewer from album activity page by [@​idubnori](https://github.com/idubnori) in [#​23182](immich-app/immich#23182) - feat(mobile): high precision seeking by [@​mertalev](https://github.com/mertalev) in [#​22346](immich-app/immich#22346) - feat(web): wasm justified layout, sync edition by [@​mertalev](https://github.com/mertalev) in [#​23194](immich-app/immich#23194) - feat: logout sessions on password change by [@​MontejoJorge](https://github.com/MontejoJorge) in [#​23188](immich-app/immich#23188) - feat(server): enhance metadata reading for video files by [@​tstachl](https://github.com/tstachl) in [#​23258](immich-app/immich#23258) - feat: improve UI for resolving duplication detection by [@​alextran1502](https://github.com/alextran1502) in [#​23145](immich-app/immich#23145) - feat: toasts by [@​jrasm91](https://github.com/jrasm91) in [#​23298](immich-app/immich#23298) - feat: asset copy by [@​danieldietzler](https://github.com/danieldietzler) in [#​23172](immich-app/immich#23172) ##### 🐛 Bug fixes - fix(web): prevent photo-only memories showing mute button by [@​meesfrensel](https://github.com/meesfrensel) in [#​22802](immich-app/immich#22802) - fix: get all assets for the Recents album on iOS by [@​alextran1502](https://github.com/alextran1502) in [#​22956](immich-app/immich#22956) - fix: tag clean up query and add tests by [@​MontejoJorge](https://github.com/MontejoJorge) in [#​22633](immich-app/immich#22633) - fix: unit overlapses value in server stats card by [@​alextran1502](https://github.com/alextran1502) in [#​22994](immich-app/immich#22994) - fix: navigate to time action by [@​midzelis](https://github.com/midzelis) in [#​20928](immich-app/immich#20928) - fix: remove assets from shared link by [@​MontejoJorge](https://github.com/MontejoJorge) in [#​22935](immich-app/immich#22935) - fix(server): only asset owner should see favorite status by [@​pwojtaszko](https://github.com/pwojtaszko) in [#​20654](immich-app/immich#20654) - fix(web): render context overlays over the scrollbar by [@​PaulSonOfLars](https://github.com/PaulSonOfLars) in [#​23007](immich-app/immich#23007) - fix(web): two scrollbars in folder view by [@​YarosMallorca](https://github.com/YarosMallorca) in [#​23045](immich-app/immich#23045) - fix: skip ML availability check if ML is disabled by [@​bo0tzz](https://github.com/bo0tzz) in [#​23053](immich-app/immich#23053) - chore: skip dialog for single merged asset by [@​shenlong-tanwen](https://github.com/shenlong-tanwen) in [#​22958](immich-app/immich#22958) - fix(mobile): notate experimental network features, cleanup mis assigned translation tags by [@​mmomjian](https://github.com/mmomjian) in [#​23021](immich-app/immich#23021) - fix(ml): pin cudnn version by [@​mertalev](https://github.com/mertalev) in [#​23110](immich-app/immich#23110) - fix(server): use GPSLongitudeRef and GPSLatitudeRef EXIF fields by [@​ruippeixotog](https://github.com/ruippeixotog) in [#​21445](immich-app/immich#21445) - fix: allow editing all images by [@​bwees](https://github.com/bwees) in [#​23144](immich-app/immich#23144) - fix: isolate freeze app on older ios device by [@​alextran1502](https://github.com/alextran1502) in [#​22509](immich-app/immich#22509) - fix: android skip posting hash response after detached from engine by [@​shenlong-tanwen](https://github.com/shenlong-tanwen) in [#​23192](immich-app/immich#23192) - fix: back/forward navigation won't reset scroll in timeline by [@​midzelis](https://github.com/midzelis) in [#​22838](immich-app/immich#22838) - fix: handle null bucketId or name in android local sync by [@​shenlong-tanwen](https://github.com/shenlong-tanwen) in [#​23224](immich-app/immich#23224) - fix: fetch original name before upload by [@​shenlong-tanwen](https://github.com/shenlong-tanwen) in [#​21877](immich-app/immich#21877) - fix: focus-trap on safari by [@​midzelis](https://github.com/midzelis) in [#​23246](immich-app/immich#23246) - fix(web): disable picture-in-picture on video viewer by [@​tstachl](https://github.com/tstachl) in [#​23318](immich-app/immich#23318) - fix: make hitbox on app bar dialog bigger by [@​bwees](https://github.com/bwees) in [#​23316](immich-app/immich#23316) - fix: clear temp cache on iOS before uploads by [@​shenlong-tanwen](https://github.com/shenlong-tanwen) in [#​23326](immich-app/immich#23326) ##### 📚 Documentation - fix(web): clarify some transcoding settings by [@​meesfrensel](https://github.com/meesfrensel) in [#​22797](immich-app/immich#22797) - docs: fix small error by [@​0xflotus](https://github.com/0xflotus) in [#​22890](immich-app/immich#22890) - docs: Expand on OpenVINO WSL HW accel by [@​Mraedis](https://github.com/Mraedis) in [#​21054](immich-app/immich#21054) - docs: clarify well-known usage by [@​jrasm91](https://github.com/jrasm91) in [#​23018](immich-app/immich#23018) - feat: move community projects and guides to immich-aweseome by [@​jrasm91](https://github.com/jrasm91) in [#​23016](immich-app/immich#23016) - fix(docs): cli upload json format example by [@​leepeuker](https://github.com/leepeuker) in [#​22858](immich-app/immich#22858) - docs: update [backup-and-restore.md](http://backup-and-restore.md) by [@​nickwebcouk](https://github.com/nickwebcouk) in [#​21065](immich-app/immich#21065) #### New Contributors - [@​Chaoscontrol](https://github.com/Chaoscontrol) made their first contribution in [#​21740](immich-app/immich#21740) - [@​meesfrensel](https://github.com/meesfrensel) made their first contribution in [#​22802](immich-app/immich#22802) - [@​0xflotus](https://github.com/0xflotus) made their first contribution in [#​22890](immich-app/immich#22890) - [@​clementmartin](https://github.com/clementmartin) made their first contribution in [#​22833](immich-app/immich#22833) - [@​leepeuker](https://github.com/leepeuker) made their first contribution in [#​22858](immich-app/immich#22858) - [@​nickwebcouk](https://github.com/nickwebcouk) made their first contribution in [#​21065](immich-app/immich#21065) - [@​idubnori](https://github.com/idubnori) made their first contribution in [#​23075](immich-app/immich#23075) - [@​ruippeixotog](https://github.com/ruippeixotog) made their first contribution in [#​21445](immich-app/immich#21445) - [@​Nykri](https://github.com/Nykri) made their first contribution in [#​22888](immich-app/immich#22888) - [@​slagiewka](https://github.com/slagiewka) made their first contribution in [#​23130](immich-app/immich#23130) - [@​khanbasharat3a1](https://github.com/khanbasharat3a1) made their first contribution in [#​22274](immich-app/immich#22274) - [@​andre-antunesdesa](https://github.com/andre-antunesdesa) made their first contribution in [#​20041](immich-app/immich#20041) - [@​RobinJ1995](https://github.com/RobinJ1995) made their first contribution in [#​20035](immich-app/immich#20035) - [@​flipped-1121](https://github.com/flipped-1121) made their first contribution in [#​18836](immich-app/immich#18836) - [@​ZacWarham](https://github.com/ZacWarham) made their first contribution in [#​23275](immich-app/immich#23275) - [@​tstachl](https://github.com/tstachl) made their first contribution in [#​23258](immich-app/immich#23258) **Full Changelog**: <immich-app/immich@v2.1.0...v2.2.0> </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0MS4xNTUuNCIsInVwZGF0ZWRJblZlciI6IjQxLjE1NS40IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJpbWFnZSJdfQ==--> Reviewed-on: https://gitea.alexlebens.dev/alexlebens/infrastructure/pulls/1904 Co-authored-by: Renovate Bot <[email protected]> Co-committed-by: Renovate Bot <[email protected]>
4 tasks
bwees
pushed a commit
to exelix11/immich
that referenced
this pull request
Nov 7, 2025
…ch-app#21445) Co-authored-by: Daniel Dietzler <[email protected]>
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Re-submission of #18403, which fixes EXIF parsing for GPS tags.
The solution for the issue requires updating
exiftool-vendoredand enabling thegeolocationoption. However, exiftool v13.22 seems to have introduced some issues with UTF-16LE file parsing (exiftool/exiftool#348), which is causing some e2e test assets to not work anymore.Given upgrading exiftool could break Immich support for existing library files, I'm implementing fallback logic in
metadata.repository.specto convert XMP files to UTF-8 if needed. I'm not sure if this is the best way to go, other suggestions are appreciated.Fixes #13053.
How Has This Been Tested?
e2e/src/api/specs/library.e2e-spec.tsuses UTF-16LE test assets and shows that those XMP files continue to be supported.Followed the test plan in #18403 and confirmed the geolocation fix still worked. I can also upload test assets with affected geo tags and put them in an e2e test if needed.
Checklist:
src/services/uses repositories implementations for database calls, filesystem operations, etc.src/repositories/is pretty basic/simple and does not have any immich specific logic (that belongs insrc/services/)