fix: default zoom level when location is not set #21428
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Map defaults to a zoom level 12.5 on the new "Manage locations" tool when no location is set. This is caused by the zoom level check only checking if the value is undefined and not if its also 0.
Result of the incorrect behavior is it looks like the map is broken (Lat/Lng of 0,0 is the middle of the ocean) see pic below:
This pr changes the check to be for both 0 and undefined (just checks truthiness of the value) in order to determine zoom level.
Result:
How Has This Been Tested?
Tested on latest webUI
Checklist:
src/services/uses repositories implementations for database calls, filesystem operations, etc.src/repositories/is pretty basic/simple and does not have any immich specific logic (that belongs insrc/services/)