fix(mobile): caching thumbnails to disk #21275
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alextran1502
approved these changes
Aug 26, 2025
Member
alextran1502
left a comment
alextran1502
left a comment
There was a problem hiding this comment.
Great work! Confirmed fix. With this, it is pretty easy to reproduce the issue of whether there is only a low-quality thumbnail, when in the asset viewer, you cannot swip up or down to perform the corresponding actions
ollioddi
pushed a commit
to ollioddi/immich
that referenced
this pull request
Aug 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The thumbnails weren't being saved at all because of how Dart streams work. This should fix it.
How Has This Been Tested?
Tested by using the app while the server container was stopped.