fix: invalid storage quota with decimals #21271
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danieldietzler
approved these changes
Aug 25, 2025
Member
|
Do we not want to allow <1 quotas? |
Member
This allows to set |
Member
|
yes, but I mean specifically sub-gigabyte nonzero quotas. |
Member
Author
|
This main thing is that this fixes the API validation to require whole numbers (in bytes), which removes the database error. I think the UI can accept decimal numbers but I don't want to work on that. It involves more code changes in several places to handle rounding to the nearest byte and such. |
ollioddi
pushed a commit
to ollioddi/immich
that referenced
this pull request
Aug 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #20982