fix: wait for watched files to finish being written (#17100) #21180
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This makes the external library watcher wait for files in watched directories to finish being written before queuing jobs for each file.
This configures chokidar with
awaitWriteFinishto wait for watched files to remain stable in size for 5 seconds before emitting its events. (https://github.com/paulmillr/chokidar?tab=readme-ov-file#performance)This should fix issues with jobs prematurely running when there are slow writes to external libraries (e.g. when the external library is written to using Samba) and failing.
Fixes #17100
Checklist:
src/services/uses repositories implementations for database calls, filesystem operations, etc.src/repositories/is pretty basic/simple and does not have any immich specific logic (that belongs insrc/services/)