fix: border around dark theme button on onboarding page #20846
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
I'll test this again to see if the Immich ui changes make it look right. |
NicholasFlamy
force-pushed
the
fix/dark-theme-button-border-onboarding
branch
from
69cd7af to
9a9579a
Compare
Member
|
Can you help with before/after screenshot? |
Collaborator
Author
Updated with screenshots! |
NicholasFlamy
force-pushed
the
fix/dark-theme-button-border-onboarding
branch
from
9a9579a to
c9b2908
Compare
alextran1502
approved these changes
Aug 23, 2025
ollioddi
pushed a commit
to ollioddi/immich
that referenced
this pull request
Aug 27, 2025
…0846) fix border around dark theme button
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes the border around the dark theme button on the theme onboarding page. The border was previously always active, but now it responds to theme change.
This depends on immich-app/ui#238 to make the color look right.
How Has This Been Tested?
make devScreenshots (if appropriate)
Before:
After:
Checklist: