fix(mobile): swiping between assets when bottom sheet is open #20842
+45
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| heroAttributes: PhotoViewHeroAttributes(tag: '${asset.heroTag}_$heroOffset'), | ||
| filterQuality: FilterQuality.high, | ||
| tightMode: true, | ||
| initialScale: PhotoViewComputedScale.contained * 0.999, |
Member
There was a problem hiding this comment.
This is for fixing the arithmetic error that causes double swiping on iOS
Member
Author
There was a problem hiding this comment.
This was already fixed in #18749's hit test arithmetic change. I haven't gotten any double swipes without the multiplier, so I don't think it's needed unless there was another reason for it @shenlong-tanwen
Member
There was a problem hiding this comment.
Nope, this was added as part of the PR to fix the double swipe issue along with the arithmetic change. I don't think we really tested that PR without the multiplier, but if it works without this, then we can remove it
Member
|
@mertalev Can you help me rebase this over main? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
After #20637, it is possible for scale and animation calculations to be off when swiping between assets with the bottom sheet open. As this is deeply related to photo_view internals, the quick fix is to disable loading the cached thumbnail in this specific case.